Skip to content

docs: describe API key expiry warnings and recipients - #444

Merged
sami-alajrami merged 7 commits into
mainfrom
docs/api-key-expiry-notifications
Oct 1, 2026
Merged

sami-alajrami merged 7 commits into
mainfrom
docs/api-key-expiry-notifications

Conversation

@sami-alajrami

Copy link
Copy Markdown
Contributor

No description provided.

@sami-alajrami
sami-alajrami requested a review from a team as a code owner October 1, 2026 12:02
@mintlify

mintlify Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
kosli 🟢 Ready View Preview Oct 1, 2026, 12:11 PM

@claude

claude Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @sami-alajrami's task in 1m 18s —— View job


Follow-up review on 8a972de (vs 6f7ca59)

Four commits landed in this push: 9ade0fa, 47d3e11, 1ded0f7, 8a972de. Within that range, the only content change touching administration/authentication/api_key_rotation.md is line 30 (plus a comment added in scripts/live_docs_fetch.py, unrelated to the doc review).

Status of previously raised findings:

  • Intro wording (replace/rotate/revoke by key kind): ✅ Resolved in the prior push — unchanged here, thread already closed.
  • "Last call" / daily-check clarity:
    • Daily-check intro — ✅ Resolved. Line 30 now states "Kosli checks for expiring keys once a day" up front.
    • Which warning is resent for a same-date rotation — ❌ Not addressed. Line 37 still just says "the next daily check warns you again" without naming first notice vs. last call. Left an inline comment on that line with the specific gap.

No new bugs or regressions found in the changed lines. 1 new inline comment (status update on the still-open half of the previous finding).

Comment thread administration/authentication/api_key_rotation.md Outdated
Comment thread administration/authentication/api_key_rotation.md
mbevc1
mbevc1 previously approved these changes Oct 1, 2026
AlexKantor87 and others added 2 commits October 1, 2026 12:04
Added a comment about the API token being a public example.
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Comment thread administration/authentication/api_key_rotation.md
@claude

claude Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Follow-up review on 6f7ca59 (vs af5d3d5)

Only one line changed in this push: the ## Expiry warnings intro paragraph.

  • Intro wording (replace/rotate/revoke by key kind): ✅ Resolved — now says "rotate a service account key, or create a new personal key and revoke the old one," matching the suggested fix. Closed the inline thread.
  • "Last call" / daily-check clarity (line 37): ❌ Not addressed — this region wasn't touched by the new commit. The page still doesn't introduce a daily check up front, and "the next daily check warns you again" still doesn't say which warning (first notice vs. last call) is resent.

No new bugs or regressions found in the changed line. 0 new inline comments beyond closing the resolved thread above.

sami-alajrami and others added 2 commits October 1, 2026 14:10
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
The branch was rebased locally onto main while the first sentence was
edited on GitHub. The edit is already cherry-picked here, so the merge
keeps the local tree and only joins the two histories.
Comment thread administration/authentication/api_key_rotation.md
@sami-alajrami
sami-alajrami enabled auto-merge (squash) October 1, 2026 12:14
mbevc1
mbevc1 previously approved these changes Oct 1, 2026
@sami-alajrami
sami-alajrami dismissed mbevc1’s stale review October 1, 2026 12:16

The merge-base changed after approval.

mbevc1
mbevc1 previously approved these changes Oct 1, 2026
@sami-alajrami
sami-alajrami dismissed mbevc1’s stale review October 1, 2026 12:22

The merge-base changed after approval.

@sami-alajrami
sami-alajrami disabled auto-merge October 1, 2026 12:28
@sami-alajrami
sami-alajrami merged commit 58d0739 into main Oct 1, 2026
6 checks passed
@sami-alajrami
sami-alajrami deleted the docs/api-key-expiry-notifications branch October 1, 2026 12:38

This branch was successfully deployed

1 active deployment
staging — 8a972deb Deployed Oct 1, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants