Skip to content

LWLP-3308: Mirror plumbing builder, bump fromager, add image build/push workflow - #1

Merged
Jonathan Gangi (JAVGan) merged 2 commits into
mainfrom
feat/LWLP-3308-python-builder-fromager-latest
Oct 21, 2026
Merged

Jonathan Gangi (JAVGan) merged 2 commits into
mainfrom
feat/LWLP-3308-python-builder-fromager-latest

Conversation

@JAVGan

Copy link
Copy Markdown
Member

Summary

  • Mirror calungaproject/plumbing's builder/ directory as this repo's Python wheel builder image (Containerfile, build scripts, fromager overrides, tests), bumping the pinned fromager dependency from 0.89.0 to the latest release (0.101.0), with requirements.txt/requirements-build.txt regenerated via pip-compile/pybuild-deps against Python 3.12
  • Add a GitHub Actions workflow (.github/workflows/container-build.yml) to build and push the image to quay.io/light-factory/python-builder on push/tag/PR/dispatch, mirroring konflux-lightwell/fath-cuan's container-build.yml

Verification

  • Confirmed the local repo is byte-identical to upstream calungaproject/plumbing/builder/ except the three fromager-pin files
  • Checked fromager's 0.89.0→0.101.0 release notes for breaking changes (none relevant) and confirmed every CLI flag scripts/build-wheels depends on (--settings-file, --settings-dir, -p/--patches-dir, -j/--jobs, -c/--constraints-file, --cache-wheel-server-url, bootstrap, build-sequence) and the fromager.project_overrides entry point are unchanged in 0.101.0
  • Installed the regenerated requirements.txt into a scratch Python 3.12 venv with --require-hashes — succeeds; installed overrides/package_plugins against it — succeeds
  • Ran a full local podman build of the Containerfile; progressed cleanly through CPython/Rust/OpenSSL/git/sqlite/etc. stages (in progress at time of writing — this is a long multi-hour build)
  • Confirmed CONTAINER_REGISTRY_USER/CONTAINER_REGISTRY_PASSWORD already exist as repo secrets, so the new workflow should authenticate without further setup

Notes

  • This Containerfile compiles CPython, Rust, OpenSSL, Arrow and ffmpeg from source across ~40 stages, producing far more layer data than a standard ubuntu-latest runner's ~14GB free disk can hold. The workflow includes a disk-space-reclaim step (removing preinstalled Android/.NET/GHC/CodeQL toolchains) to mitigate this — worth revisiting if a larger/self-hosted runner is preferred instead.

Jira: LWLP-3308

🤖 Generated with Claude Code

Brings in the plumbing project's manylinux-style builder image
(Containerfile, build scripts, fromager overrides, tests) as the base
for Lightwell's Python wheel builder, with the pinned fromager
dependency updated from 0.89.0 to the latest release (0.101.0).
requirements.txt/requirements-build.txt regenerated accordingly via
pip-compile/pybuild-deps against Python 3.12.

LWLP-3308

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
build/ and src/calunga_package_plugins.egg-info/ were generated by a
local pip install during verification and don't belong in source
control. Ignore both going forward.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@JAVGan
Jonathan Gangi (JAVGan) marked this pull request as ready for review October 20, 2026 17:35

@arewm Andrew McNamara (arewm) left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my local agentic review,

Upstream's test.yml actually tests the builder (test-build-wheels, collect-build-files tests, path-filtered). This PR brings over the test files but not the test workflow — the only CI here is the image build. If upstream parity and correctness matter, porting a test job (or at least test-collect-build-files.sh, which is cheap) would catch regressions that a successful image build won't.

Also, can we build this in Konflux instead of using GitHub Actions?

@JAVGan
Jonathan Gangi (JAVGan) force-pushed the feat/LWLP-3308-python-builder-fromager-latest branch from 967fae3 to ad70705 Compare October 21, 2026 13:34
@JAVGan
Jonathan Gangi (JAVGan) merged commit a7fe1e3 into main Oct 21, 2026
@arewm
Andrew McNamara (arewm) deleted the feat/LWLP-3308-python-builder-fromager-latest branch October 21, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants