Repository navigation
LWLP-3308: Mirror plumbing builder, bump fromager, add image build/push workflow - #1
Merged
Jonathan Gangi (JAVGan) merged 2 commits intoOct 21, 2026
Conversation
Brings in the plumbing project's manylinux-style builder image (Containerfile, build scripts, fromager overrides, tests) as the base for Lightwell's Python wheel builder, with the pinned fromager dependency updated from 0.89.0 to the latest release (0.101.0). requirements.txt/requirements-build.txt regenerated accordingly via pip-compile/pybuild-deps against Python 3.12. LWLP-3308 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
build/ and src/calunga_package_plugins.egg-info/ were generated by a local pip install during verification and don't belong in source control. Ignore both going forward. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Jonathan Gangi (JAVGan)
marked this pull request as ready for review
October 20, 2026 17:35
Andrew McNamara (arewm)
requested changes
Oct 20, 2026
There was a problem hiding this comment.
Based on my local agentic review,
Upstream's
test.ymlactually tests the builder (test-build-wheels, collect-build-files tests, path-filtered). This PR brings over the test files but not the test workflow — the only CI here is the image build. If upstream parity and correctness matter, porting a test job (or at leasttest-collect-build-files.sh, which is cheap) would catch regressions that a successful image build won't.
Also, can we build this in Konflux instead of using GitHub Actions?
Jonathan Gangi (JAVGan)
force-pushed
the
feat/LWLP-3308-python-builder-fromager-latest
branch
from
October 21, 2026 13:34
967fae3 to
ad70705
Compare
Andrew McNamara (arewm)
approved these changes
Oct 21, 2026
Andrew McNamara (arewm)
deleted the
feat/LWLP-3308-python-builder-fromager-latest
branch
October 21, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calungaproject/plumbing'sbuilder/directory as this repo's Python wheel builder image (Containerfile, build scripts, fromager overrides, tests), bumping the pinnedfromagerdependency from0.89.0to the latest release (0.101.0), withrequirements.txt/requirements-build.txtregenerated viapip-compile/pybuild-depsagainst Python 3.12.github/workflows/container-build.yml) to build and push the image toquay.io/light-factory/python-builderon push/tag/PR/dispatch, mirroringkonflux-lightwell/fath-cuan'scontainer-build.ymlVerification
calungaproject/plumbing/builder/except the three fromager-pin filesscripts/build-wheelsdepends on (--settings-file,--settings-dir,-p/--patches-dir,-j/--jobs,-c/--constraints-file,--cache-wheel-server-url,bootstrap,build-sequence) and thefromager.project_overridesentry point are unchanged in 0.101.0requirements.txtinto a scratch Python 3.12 venv with--require-hashes— succeeds; installedoverrides/package_pluginsagainst it — succeedspodman buildof the Containerfile; progressed cleanly through CPython/Rust/OpenSSL/git/sqlite/etc. stages (in progress at time of writing — this is a long multi-hour build)CONTAINER_REGISTRY_USER/CONTAINER_REGISTRY_PASSWORDalready exist as repo secrets, so the new workflow should authenticate without further setupNotes
ubuntu-latestrunner's ~14GB free disk can hold. The workflow includes a disk-space-reclaim step (removing preinstalled Android/.NET/GHC/CodeQL toolchains) to mitigate this — worth revisiting if a larger/self-hosted runner is preferred instead.Jira: LWLP-3308
🤖 Generated with Claude Code