Skip to content

Refactor dark mode implementation and improve styling consistency#350

Open
SRSoham wants to merge 1 commit into
komalharshita:mainfrom
SRSoham:darkmode-clean
Open

Refactor dark mode implementation and improve styling consistency#350
SRSoham wants to merge 1 commit into
komalharshita:mainfrom
SRSoham:darkmode-clean

Conversation

@SRSoham
Copy link
Copy Markdown

@SRSoham SRSoham commented May 20, 2026

Changes Made

This PR refactors and improves the previous dark mode implementation after review feedback from the earlier PR (#248).

Improvements

  • Refactored dark mode styling to use scoped [data-theme="dark"] component-based overrides
  • Reduced unnecessary global overrides and excessive !important usage
  • Improved maintainability and readability of dark mode CSS architecture
  • Fixed UI inconsistencies across multiple sections of the application
  • Improved contrast, readability, and accessibility in dark mode
  • Cleaned up duplicated/redundant styling where possible

Updated Components

  • Hero section
  • Feature cards
  • Buttons and interactive elements
  • Form sections and inputs
  • GitHub import button
  • Skill strip / tech stack marquee
  • Cards, labels, and support sections
  • Dark mode icon styling

Fixes

  • Fixed overflow/layout issues in skill-strip section
  • Fixed light backgrounds appearing in dark mode
  • Fixed inconsistent card/button appearance
  • Improved dark mode responsiveness and visual consistency
  • Corrected text visibility issues in dark theme

Previous PR

This PR continues and refines the earlier dark mode implementation:

Testing

Tested locally for:

  • Dark/light theme switching
  • Desktop responsiveness
  • Form visibility and readability
  • Buttons/cards/labels consistency
  • Hero and feature sections
  • Skill strip layout and overflow behavior

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

@SRSoham is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@SRSoham
Copy link
Copy Markdown
Author

SRSoham commented May 20, 2026

Hi @komalharshita,
Addressed the review feedback from the previous PR by refactoring the dark mode implementation into a cleaner component-based structure.

Key updates:

  • replaced large global overrides with scoped [data-theme="dark"] styling
  • reduced unnecessary !important usage
  • improved consistency across cards, forms, buttons, hero sections, and skill-strip components
  • fixed contrast/readability issues in dark mode
  • cleaned up duplicated and redundant styling
  • fixed layout and overflow issues in the tech stack section

Tested locally for theme switching, responsiveness, and UI consistency across major sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant