feat: add 403 forbidden error handler#348
Open
rudra3007-pro wants to merge 1 commit into
Open
Conversation
|
@rudra3007-pro is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a 403 Forbidden error handler to match the existing 404, 405 and 500 handlers in
app.py. Also added a styledtemplates/403.htmlpage consistent with the rest of the error pages in the app.Related Issue
Closes #347
Type of Change
What Was Changed
app.pyforbiddenerror handler for 403templates/403.htmlHow to Test This PR
git checkout feat/403-error-handlerpip install -r requirements.txtpython app.pycurl -X GET http://127.0.0.1:5000/forbiddenpython tests/test_basic.pyTest Results
(.venv) PS C:\Users\AKM\OneDrive\Desktop\new\DevPath> python tests/test_basic.py
PASS test_projects_json_loads
PASS test_each_project_has_required_fields
PASS test_find_project_by_id_found
PASS test_find_project_by_id_missing
PASS test_parse_skills_basic
PASS test_parse_skills_empty_string
PASS test_parse_skills_single_entry
PASS test_score_single_project_full_match
PASS test_score_single_project_no_match
PASS test_get_recommendations_returns_results
PASS test_get_recommendations_max_three
PASS test_get_recommendations_no_match_returns_empty
PASS test_get_recommendations_result_format
PASS test_validate_all_valid
PASS test_validate_missing_skills
PASS test_validate_missing_level
PASS test_validate_missing_interest
PASS test_validate_missing_time
PASS test_validate_all_missing
PASS test_home_route
PASS test_recommend_api_valid
PASS test_recommend_api_missing_field
PASS test_recommend_api_empty_body
PASS test_project_detail_found
PASS test_project_detail_not_found
PASS test_internal_server_error_page
PASS test_view_code_found
PASS test_download_code_found
PASS test_health_check
PASS test_scoring_weights_has_all_keys
30 passed, 0 failed out of 30 tests
Self-Review Checklist
feat/403-error-handlerflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
Follows the exact same pattern as the existing 404, 405 and 500 handlers. The 403.html template reuses the same CSS classes as 404.html, only the error code and message differ.