Skip to content

fix: resolve form ui inconsistencies and restore marquee styles#336

Open
tanmayythakare wants to merge 1 commit into
komalharshita:mainfrom
tanmayythakare:fix/form-ui-inconsistencies
Open

fix: resolve form ui inconsistencies and restore marquee styles#336
tanmayythakare wants to merge 1 commit into
komalharshita:mainfrom
tanmayythakare:fix/form-ui-inconsistencies

Conversation

@tanmayythakare
Copy link
Copy Markdown

@tanmayythakare tanmayythakare commented May 19, 2026

Summary

This PR resolves multiple form layout, visual inconsistencies, and JavaScript syntax bugs on the homepage (Issue #308):

  1. Dropdown Redesign: Replaced the default native browser select dropdowns (Experience Level, Area of Interest, and Time Availability) with fully styled, theme-compliant custom select dropdown components.
  2. Duplicate Skills Placeholder: Fixed a HTML syntax issue where a malformed tag in the skills section caused a duplicate input field and placeholder to render.
  3. Syntax Repairs: Repaired multiple unclosed code block parser syntax errors in static/script.js that broke script execution.
  4. Button Realignment & Polish: Removed a duplicate "Generate My Projects" submit button and styled the "Clear Filters" button in a single row to match theme dimensions, borders, and hover states.
  5. Marquee Restoration: Restored missing marquee track styles in static/style.css so the horizontal skills ticker rolls smoothly on a single line instead of stacking vertically.

Related Issue

Closes #308

Type of Change

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed [required]

File Change made
templates/index.html Removed duplicate submit button, removed inline styling block, and implemented custom select triggers/options containers.
static/style.css Implemented select trigger, option list, active state styles, custom clear filter button spacing, and restored the original .skill-strip-marquee and .skill-strip-track rules.
static/script.js Handled custom dropdown interactions, outside-clicks, and resolved unclosed syntax errors from previous merges.

How to Test This PR

  1. Clone this branch: git checkout fix/form-ui-inconsistencies
  2. Run the app: python app.py
  3. Open http://127.0.0.1:5000 and confirm:
    • Experience Level, Area of Interest, and Time Availability use custom dropdown panels.
    • Skill marquee scrolls infinitely on a single line.
    • "Generate My Projects" and "Clear Filters" align nicely in a single row.
  4. Run the tests: python tests/test_basic.py

Expected test output:

Screenshots (if UI change)

Before After
Screenshot 2026-05-19 233509 Screenshot 2026-05-20 001709

Self-Review Checklist

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: fix/form-ui-inconsistencies
  • I have run python tests/test_basic.py and all 30 tests pass
  • I have run flake8 . locally and there are no errors (or it's not configured)
  • I have not introduced any print() or console.log() debug statements
  • Every new function I wrote has a docstring (or is inline event handler)
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)

Notes for Reviewer

The custom select component directly links to and updates the value of the hidden native <select> element, ensuring that form submissions, client-side validation, and API fetch payloads remain fully backward-compatible.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

@tanmayythakare is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Duplicate Skills Placeholder Text & Unstyled Dropdown UI in Project Generator Form

1 participant