fix: resolve form ui inconsistencies and restore marquee styles#336
Open
tanmayythakare wants to merge 1 commit into
Open
fix: resolve form ui inconsistencies and restore marquee styles#336tanmayythakare wants to merge 1 commit into
tanmayythakare wants to merge 1 commit into
Conversation
|
@tanmayythakare is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves multiple form layout, visual inconsistencies, and JavaScript syntax bugs on the homepage (Issue #308):
static/script.jsthat broke script execution.static/style.cssso the horizontal skills ticker rolls smoothly on a single line instead of stacking vertically.Related Issue
Closes #308
Type of Change
data/projects.jsonWhat Was Changed [required]
templates/index.htmlstatic/style.css.skill-strip-marqueeand.skill-strip-trackrules.static/script.jsHow to Test This PR
git checkout fix/form-ui-inconsistenciespython app.pypython tests/test_basic.pyExpected test output:
Screenshots (if UI change)
Self-Review Checklist
fix/form-ui-inconsistenciespython tests/test_basic.pyand all 30 tests passflake8 .locally and there are no errors (or it's not configured)print()orconsole.log()debug statementsNotes for Reviewer
The custom select component directly links to and updates the value of the hidden native
<select>element, ensuring that form submissions, client-side validation, and API fetch payloads remain fully backward-compatible.