fix: Resolved the time availability bug #304
Open
Triv24 wants to merge 2 commits into
Open
Conversation
…aving same or lower time availability as set by user.
|
@Triv24 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@Triv24 ensure that all checks pass |
…efactor/recommendation-engine
Author
|
I have rebased the main branch with a clean test_basic.py file. Kindly check once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return the projects with same or lower time availability as set by the user.
Summary [required]
Firstly, the recommendation engine used to return the projects with high time availability even when the time availability was set to low by the user. This PR refactors the engine, and the results only contain projects with the same time avaijlability or a lower one as set by the user.
Related Issue [required]
Closes #212
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
utils/recommender.pyscore_single_project()functionHow to Test This PR [required]
git checkout your-branch-namepip install -r requirements.txtpython app.pypython tests/test_basic.pyExpected test output:
Test Results [required]
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
There is NO Issue with the refactoring in this PR. One of the tests in
tests/test_basic.pyFailed because it was written wrongly in some PR. Another issue is opened for the required fix intest_basic.pyalready.