Context embedding based suggestions#289
Conversation
VaibhavA123
commented
May 18, 2026
- Offline preprocessing script successfully vectorized and serialized all dataset profiles.
- Mathematical dot-product calculations verified locally return matching indices under 15ms.
- Graceful error management fallback implemented to guarantee operational search pathways if the external API hits rate limits.
|
@VaibhavA123 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for the contribution. This PR introduces a very ambitious semantic recommendation system using Gemini embeddings, Redis-based interaction history, Kafka event logging, and cosine similarity matching. There is clearly a significant amount of engineering effort and thoughtful system design behind the implementation.
However, this PR is currently not merge-ready because it introduces a major architectural expansion that goes far beyond a standard feature addition for the current DevPath stack.
Main concerns:
- The PR introduces substantial new infrastructure dependencies (Redis, Kafka, Gemini embedding APIs) without corresponding setup/configuration/documentation for maintainers or contributors.
- No tests were added for the new APIs, semantic matching pipeline, Redis/Kafka integrations, or failure scenarios.
- The feature currently lacks graceful fallback behavior when external systems/services fail.
- Using pickle-based embedding persistence introduces maintainability and safety concerns.
- The recommendation pipeline currently loads embeddings and computes similarity synchronously per request, which may not scale well.
- This level of infrastructure change likely requires architectural discussion/design approval before merging.
Positive note:
The semantic matching concept itself is strong, and the separation of preprocessing/helpers shows good engineering intent. However, this would be better approached as a phased architecture initiative with:
- proper dependency setup
- environment documentation
- testing strategy
- fallback handling
- deployment planning
- scalability considerations
At the moment, the implementation is too large and infrastructure-heavy to merge safely in its current form.