style: improve navbar hover underline animation#282
Conversation
|
@pari-dubey1 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@komalharshita Hi! I’ve completed the changes in this PR. Everything has been tested locally and is working properly now. Could you please review and merge this PR into the main branch when you get a chance? Thank you! |
komalharshita
left a comment
There was a problem hiding this comment.
Well-scoped and clean UI enhancement. The updated navbar hover animation feels smoother and more polished, and the mobile hamburger visibility fix is a good addition.
The PR keeps changes limited to relevant styling updates without introducing unnecessary modifications. The centered underline animation implementation is handled well.
Approved for merge.
|
@pari-dubey1 but first ensure that all checks pass |
|
@komalharshita I checked the failing CI logs, and the failure seems unrelated to the navbar styling changes in this PR. The failing test is:
All other tests are passing successfully, so it appears to be an existing test/configuration issue rather than something introduced by this PR. |
|
@pari-dubey1 sync your branch with the latest main |
Summary [required]
Added a smoother and more modern animated underline hover effect for navbar links to improve visual feedback and overall navigation interactivity.
The underline animation now expands from the center with a 75% width effect, creating a cleaner and more polished UI experience.
Also fixed the mobile hamburger menu visibility issue caused during styling updates.
Related Issue [required]
Closes #215
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
static/style.cssHow to Test This PR [required]
Clone this branch:
git checkout style/navbar-hover-underlineInstall dependencies:
pip install -r requirements.txtRun the app:
python app.pyOpen:
http://127.0.0.1:5000Hover over navbar links and verify:
Run the tests:
python tests/test_basic.pyExpected output:
Test Results [required]
Screenshots (if UI change)
Before:
After:
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
This PR only updates navbar styling and hover interactions. No application logic or backend functionality was modified.