add WithIgnoreUndefined option to config parse#1839
Open
zackattack01 wants to merge 1 commit intomainfrom
Open
add WithIgnoreUndefined option to config parse#1839zackattack01 wants to merge 1 commit intomainfrom
zackattack01 wants to merge 1 commit intomainfrom
Conversation
Contributor
|
@RebeccaMahany Would this have eliminated the need for |
Contributor
|
@directionless -- I don't think so. Unless the behavior has changed -- the last time I looked into it when I ultimately added Separately, I am not sure if this PR will address #1513 -- older launcher installations without this option set will still run into this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if an unknown option is found in our launcher.flags the parser will stop parsing and return an error which is not checked/logged. This adds an option to the parser to prevent this behavior and continue parsing, discarding the unknown flag