Metadata Refactor and Standardization#332
Open
Googolplexed0 wants to merge 2 commits intokokarare1212:mainfrom
Open
Metadata Refactor and Standardization#332Googolplexed0 wants to merge 2 commits intokokarare1212:mainfrom
Googolplexed0 wants to merge 2 commits intokokarare1212:mainfrom
Conversation
slight ApiClient exception improvements version bump v0.0.11
There was a problem hiding this comment.
Pull request overview
This pull request refactors the metadata ID classes to use a unified base class approach and improves error messages in API client methods. The PR bumps the version from 0.0.10 to 0.0.11.
Changes:
- Consolidated metadata ID classes (TrackId, AlbumId, ArtistId, etc.) to inherit from a new base
Idclass, reducing code duplication - Improved error messages in ApiClient to include contextual information (URIs) when requests fail
- Changed parameter name from
_idtoplaylistin get_playlist() method for better readability
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| setup.py | Version bump from 0.0.10 to 0.0.11 |
| librespot/init.py | Version bump from 0.0.10 to 0.0.11 |
| librespot/metadata.py | Major refactoring: consolidated ID classes into a base Id class with shared implementation, changed internal representation from hex to base62 |
| librespot/core.py | Improved error messages to include URIs, renamed parameter from _id to playlist, added blank lines for readability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slight ApiClient exception improvements
version bump v0.0.11