ip/ipreassembler: fix positive header_delta push path#419
Open
pallas wants to merge 1 commit intokohler:masterfrom
Open
ip/ipreassembler: fix positive header_delta push path#419pallas wants to merge 1 commit intokohler:masterfrom
pallas wants to merge 1 commit intokohler:masterfrom
Conversation
Like the put earlier in this method, the push here can fail or reallocate the SKB. In the former case, we need to clean up (as above) and in both cases, we need to update the linkage into q from it's predecessor. Thanks: --enable-force-expensive + Valgrind Signed-off-by: Derrick Pallas <pallas@meraki.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like the put earlier in this method, the push here can fail or reallocate
the SKB. In the former case, we need to clean up (as above) and in both
cases, we need to update the linkage into q from it's predecessor.
Thanks: --enable-force-expensive + Valgrind
Signed-off-by: Derrick Pallas pallas@meraki.com