refactor(GrlcSpec): delegate to QueryTemplate (nanopub-java 1.89.0)#109
Merged
Conversation
…nanopub-java 1.89.0 Bumps nanopub-java to 1.89.0 (which ships QueryTemplate) and reworks GrlcSpec to wrap it. Statement-walking over the assertion, SPARQL parsing, placeholder extraction and query expansion now live upstream; GrlcSpec keeps only the request-URL parsing, nanopub fetch cache, _nanopub_trig handling, api-version=latest resolution, canonical endpoint rewriting to NANOPUB_QUERY_URL/repo/, and the legacy getSpec() YAML rendering. The local KPXL_GRLC vocabulary class is removed; those IRIs are owned by QueryTemplate now. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 1.14.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.nanopub:nanopubto1.89.0(replacing the temporary Jitpack snapshot pin) so we can pick up the newQueryTemplateAPI.GrlcSpecto wrapQueryTemplate: assertion walking, SPARQL parsing, placeholder extraction and query expansion all move upstream.GrlcSpeckeeps only the Nanopub-Query-specific concerns — request-URL parsing, the nanopub fetch cache, the_nanopub_trigparameter,api-version=latestresolution, canonical endpoint rewriting toNANOPUB_QUERY_URL/repo/, and the legacygetSpec()YAML rendering for/grlc-spec/.vocabulary/KPXL_GRLCclass;kpxl_grlc:endpointandkpxl_grlc:sparqlare now owned byQueryTemplate.Net effect: ~190 lines removed for ~100 added, no behavioral change intended. Static placeholder helpers on
GrlcSpecstill exist and forward toQueryTemplateso callers likeOpenApiSpecPagekeep compiling.Test plan
mvn verifypasses./api/RA…/{name}.rq) returns the expected expanded SPARQL./grlc-spec/page still renders the expected YAML (title/description/contact/licence/queries for the index, and#+ summary/#+ endpointfor an individual query)._nanopub_triginline-nanopub parameter still works.api-version=lateststill resolves to the latest version via the meta repo.🤖 Generated with Claude Code