Skip to content

chore(kno-12198): fix callout to use type prop #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotidodson merged 2 commits into from
Mar 23, 2026
Merged

chore(kno-12198): fix callout to use type prop #1362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6242285
chore(kno-12198): fix callout to use type prop
scotidodson Mar 23, 2026
198638b
second callout updated
scotidodson Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions content/integrations/overview.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ To add a condition to a channel's environment configuration, navigate to **Chann
Knock will execute your channel conditions for every step using the given channel across all your workflow runs. Knock will join these channel conditions with any [step conditions](/designing-workflows/step-conditions) via an `AND`, meaning both channel and step conditions will need to pass evaluation for the step to execute. You can then use Knock's [conditions debugger](/concepts/conditions#debugging-conditions) to examine the evaluations of your channel conditions.

<Callout
emoji="💡"
type="info"
Copy link

@cursor cursor bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Callout type mismatch: info used for warning content

Low Severity

This Callout uses type="info" but its content warns about a side effect — sandbox mode silently prevents channel conditions from being evaluated, and tells users to disable sandbox mode for conditions to take effect. Per the project's Callout validation rules, content that warns about potential problems or side effects fits type="warning" rather than type="info".

Fix in Cursor Fix in Web

Copy link
Contributor Author

@scotidodson scotidodson Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is appropriate as info. This callout describes expected behavior. We recently had a customer face confusion trying to use these things together, so this callout is an attempt to make the information more visible.

title="Channel conditions don't override sandbox mode."
text="If sandbox mode is enabled for a channel, Knock skips execution entirely and channel conditions are not evaluated. Disable sandbox mode for conditions to take effect."
/>
Expand All @@ -116,7 +116,7 @@ You may encounter a use case where you consistently want to send the same templa
Channel groups solve this problem. With a channel group, you can combine multiple providers into a single channel that you can use to send the a single notification template across multiple providers. As an example, I could have a "Push" channel group that hosts my connections for APNs and FCM, then use that single "Push" step for any workflows where I want to notify users across my mobile apps.

<Callout
emoji="🚧"
type="beta"
title="Request channel groups."
text={
<>
Expand Down
Loading