Repository navigation
Fix doctor on fresh clones and pull lock contention (knit) - #266
Merged
marc-merino merged 2 commits intoOct 22, 2026
Merged
Conversation
knit doctor, knit migrate and knit project list read every JSON file in .knit/projects as a project, so the known-repos sidecar a fresh clone writes there made doctor fail and could be rewritten by migrate. They now read only *.project.json. knit pull --bundles syncs each open bundle's landing plans on parallel threads, and every sync takes the landing-sync file lock, which refuses a second holder even within the same process. Bundles failed with "Another Knit process is updating this state" naming the pull's own pid. Plan syncs within one pull now queue behind a mutex; the file lock still guards other processes. Knit-Group: kg_20261022_2be55a Knit-Bundle: fix-doctor-on-fresh-clones-and-pull-lock-contention
Knit-Group: kg_20261022_f4856b Knit-Bundle: fix-doctor-on-fresh-clones-and-pull-lock-contention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knit Bundle
View bundle
This PR is part of Knit bundle
fix-doctor-on-fresh-clones-and-pull-lock-contention.See the other review objects in this bundle:
knit: Fix doctor on fresh clones and pull lock contention (knit) #266 (this PR)Bundle id:
fix-doctor-on-fresh-clones-and-pull-lock-contentionBundle title: Fix doctor on fresh clones and pull lock contention