Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 90.58% 90.68% +0.09%
==========================================
Files 17 18 +1
Lines 6342 6494 +152
Branches 1152 1176 +24
==========================================
+ Hits 5745 5889 +144
- Misses 560 568 +8
Partials 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a browser-facing entrypoint for @knighted/css, wires it into the Playwright test app, and provides unit/e2e coverage for the new browser API.
Changes:
- Introduces
cssFromSourcebrowser API (packages/css/src/browser.ts) with support for plain CSS, Sass, Less, and Lightning CSS modules, plus comprehensive unit tests. - Exposes the browser build and types via
@knighted/csspackage exports and updates dependent versions in the Playwright package. - Adds a Playwright browser-entrypoint HTML fixture, E2E test, and a script to symlink the CSS dist directory into the Playwright app for import map resolution.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/css/src/browser.ts | Implements the browser-side cssFromSource API used in the new browser entrypoint. |
| packages/css/test/css.browser.test.ts | Adds unit tests covering each dialect and error path of the browser API. |
| packages/css/package.json | Bumps version and exposes the new ./browser entrypoint and types. |
| packages/playwright/browser-entrypoint.html | Defines the browser import map and demo page that exercise the browser entrypoint. |
| packages/playwright/test/browser-entrypoint.spec.ts | Adds Playwright E2E test to verify the browser entrypoint behavior in the demo page. |
| packages/playwright/scripts/link-css-dist.js | Adds script to create a symlink exposing packages/css/dist under the Playwright web root. |
| packages/playwright/package.json | Wires the symlink script into pretest and updates @knighted dependency versions. |
| packages/playwright/dist-css | Adds a generated path/symlink target that appears to be an accidental commit and conflicts with the new symlink script. |
Comments suppressed due to low confidence (1)
packages/playwright/dist-css:1
- This file contains an absolute local filesystem path (including a username) and appears to be a generated symlink target, which both leaks environment details and will not work on other machines; it should be removed from version control and created dynamically via the
link-css-dist.jsscript instead.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.