Skip to content

feat: browser entrypoint.#75

Merged
knightedcodemonkey merged 2 commits intomainfrom
bananas
Feb 2, 2026
Merged

feat: browser entrypoint.#75
knightedcodemonkey merged 2 commits intomainfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings February 1, 2026 20:23
@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.68%. Comparing base (1c0d075) to head (abfc18f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/css/src/browser.ts 94.73% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   90.58%   90.68%   +0.09%     
==========================================
  Files          17       18       +1     
  Lines        6342     6494     +152     
  Branches     1152     1176      +24     
==========================================
+ Hits         5745     5889     +144     
- Misses        560      568       +8     
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a browser-facing entrypoint for @knighted/css, wires it into the Playwright test app, and provides unit/e2e coverage for the new browser API.

Changes:

  • Introduces cssFromSource browser API (packages/css/src/browser.ts) with support for plain CSS, Sass, Less, and Lightning CSS modules, plus comprehensive unit tests.
  • Exposes the browser build and types via @knighted/css package exports and updates dependent versions in the Playwright package.
  • Adds a Playwright browser-entrypoint HTML fixture, E2E test, and a script to symlink the CSS dist directory into the Playwright app for import map resolution.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/css/src/browser.ts Implements the browser-side cssFromSource API used in the new browser entrypoint.
packages/css/test/css.browser.test.ts Adds unit tests covering each dialect and error path of the browser API.
packages/css/package.json Bumps version and exposes the new ./browser entrypoint and types.
packages/playwright/browser-entrypoint.html Defines the browser import map and demo page that exercise the browser entrypoint.
packages/playwright/test/browser-entrypoint.spec.ts Adds Playwright E2E test to verify the browser entrypoint behavior in the demo page.
packages/playwright/scripts/link-css-dist.js Adds script to create a symlink exposing packages/css/dist under the Playwright web root.
packages/playwright/package.json Wires the symlink script into pretest and updates @knighted dependency versions.
packages/playwright/dist-css Adds a generated path/symlink target that appears to be an accidental commit and conflicts with the new symlink script.
Comments suppressed due to low confidence (1)

packages/playwright/dist-css:1

  • This file contains an absolute local filesystem path (including a username) and appears to be a generated symlink target, which both leaks environment details and will not work on other machines; it should be removed from version control and created dynamically via the link-css-dist.js script instead.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 28aa3b4 into main Feb 2, 2026
8 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch February 2, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant