feat(web-synth): add new node improvements and DC Offset node - #745
Conversation
…ix Reverb Mix - Fixed Reverb Mix param wiring in store.ts - Implemented Phase Inversion toggle in GainNode with UI - Implemented true bypass mode for FilterNode using dry/wet gains with UI - Added new DC Offset node and integrated it into the app - Updated JOURNAL.md with new tasks and marked completed ones Co-authored-by: kkd16 <112675076+kkd16@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 participant
This PR adds several new features and improvements to the
web-synth-9x1aproject based on autonomous exploration.store.ts. It's now correctly wired up.GainNodethat multiplies the gain by -1.FilterWrapperto use a dry/wet crossfade strategy, allowing the filter to be fully bypassed without disconnecting the signal path. A "Bypass" checkbox was added to the UI.DcOffsetNodeusing aConstantSourceNode, providing a simple constant value source.JOURNAL.md, and the implemented ones were marked as completed.PR created automatically by Jules for task 14625529085239386943 started by @kkd16