feat(web-synth): implement noise types, mute toggle, and reset buttons - #744
Conversation
- Implemented Pink and Brown noise generation in `NoiseWrapper`. - Added a noise type selector dropdown to `NoiseNode.tsx`. - Implemented Mute toggle functionality in `GainWrapper`. - Added a mute checkbox to `GainNode.tsx`. - Added a 'Reset to Default' button to both `GainNode.tsx` and `OscillatorNode.tsx`. - Updated `JOURNAL.md` to reflect completed Expansion Phase 7 tasks. Co-authored-by: kkd16 <112675076+kkd16@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 participant
This PR introduces several improvements to the Web Synth project as part of Expansion Phase 7:
NoiseNodenow supports Pink and Brown noise. The Web AudioAudioBufferis correctly regenerated, utilizing an internal proxyGainNodeoutput so that downstream connections are kept intact during buffer replacements.GainNodenow includes a simple mute checkbox. It correctly toggles the gain to 0 while preserving the previous manual gain setting.GainNodeandOscillatorNodehave received a "Reset to Default" utility button to reset all values instantly.JOURNAL.mdfile was extended to include Phase 7 and tasks were marked as completed.PR created automatically by Jules for task 3703101980359572964 started by @kkd16