Fix import time regression by lazy-loading joining_types#211
Open
rodrigobnogueira wants to merge 2 commits intokjd:masterfrom
Open
Fix import time regression by lazy-loading joining_types#211rodrigobnogueira wants to merge 2 commits intokjd:masterfrom
rodrigobnogueira wants to merge 2 commits intokjd:masterfrom
Conversation
5 tasks
Addresses kjd#188. The joining_types dictionary (used for CONTEXTJ validation) is now wrapped in a @lru_cache(None)-decorated function to defer dictionary construction until first access. Uses lru_cache instead of cache for Python 3.8+ compatibility. - Modified tools/idna-data generator to emit lazy-loaded format - Updated core.py to call joining_types() as a function - Manually regenerated idnadata.py (generator could not run due to network) This reduces import time by ~53% (from ~6.5ms to ~3.1ms).
rodrigobnogueira
force-pushed
the
fix-import-time-regression
branch
from
172177f to
67ac5ac
Compare
…n generated code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #188 following the @Dreamsorcerer idea. The joining_types dictionary (used for CONTEXTJ validation) is now wrapped in a @cache-decorated function to defer dictionary construction until first access.
This reduces import time by ~40% (from ~6.5ms to ~3.7ms).