Changed the annotated type of data parameter in the encode and decode method

[subhajitsaha01]

In the test_idna.py file, for the data parameter of the decode method of the Codec class, a string value has been passed and accepted but the annotated type is only bytes. I have changed the static annotated type to str|bytes.

Links for the test file line, where the string values are passed to the data parameter of the decode method of the Codec class :

idna/tests/test_idna.py

Line 267 in cde1d8a

self.assertEqual(

idna/tests/test_idna.py

Line 271 in cde1d8a

self.assertEqual(

idna/tests/test_idna.py

Line 275 in cde1d8a

self.assertEqual(decode("abc.abc"), "abc.abc")

In the test_idna.py file, for the data parameter of the encode method of the Codec class, a bytes value has been passed and accepted but the annotated type is only str. I have changed the static annotated type to str|bytes.

Link for the test file line, where the bytes values are passed to the data parameter of the encode method of the Codec class :

idna/tests/test_idna.py

Line 256 in cde1d8a

self.assertRaises(idna.IDNAError, encode, b"\x0a\x33\x81")

[subhajitsaha01]

Hi @kjd is there anything I could do to get this PR resolved

[kjd]

Hi @kjd is there anything I could do to get this PR resolved

Well, passing the build tests would be a good start. The PR didn't look like it was written by a human so did not spend further time on it.

[subhajitsaha01]

Hi @kjd is there anything I could do to get this PR resolved

Well, passing the build tests would be a good start. The PR didn't look like it was written by a human so did not spend further time on it.

The Build tests are failing because the union of types are allowed after python version 3.10 and thus are failing for python versions 3.8 and 3.9.

I need to change the format of type data: str | bytes to data : Union[str, bytes] to make it universally compatible.

Do tell me if I should proceed with the same?