Update GitHub Actions and linting configurations#25
Conversation
Apply every pending Dependabot update directly instead of merging the six open PRs: - Python deps (uv.lock): psutil, textual, ruff, tombi, ty, types-psutil, pytest, pillow, aiohttp->requests and all transitives via `uv lock --upgrade` - GitHub Actions: github-labelmanager v1->v2, deploy-pages v4->v5, github-script v8->v9, upload-artifact v6->v7, download-artifact v7->v8, attest-build-provenance v3->v4 Fix breakage surfaced by the newer toolchain so CI stays green: - ruff 0.15: ignore PLW0717 (too-many-try-statements) - the psutil process_iter guard legitimately wraps many statements in one try - ty 0.0.44: drop removed rules byte-string-type-annotation and fstring-type-annotation from ty.toml - docs.py: guard token.map (now typed list[int] | None) instead of a stale mypy-style type: ignore that ty doesn't honor
📦 Test this PR (archived)
This PR has been merged. You can still test the final state: uvx --from git+https://github.com/kjanat/procclean@2e71d06185307b2fb1c0c6cb4366da87b52f1937 procclean📋 PR Details
Merge commit: Available commands: # Launch TUI (default)
uvx --from git+https://github.com/kjanat/procclean@2e71d06185307b2fb1c0c6cb4366da87b52f1937 procclean
# List processes
uvx --from git+https://github.com/kjanat/procclean@2e71d06185307b2fb1c0c6cb4366da87b52f1937 procclean list
# Show memory summary
uvx --from git+https://github.com/kjanat/procclean@2e71d06185307b2fb1c0c6cb4366da87b52f1937 procclean mem
# Show help
uvx --from git+https://github.com/kjanat/procclean@2e71d06185307b2fb1c0c6cb4366da87b52f1937 procclean --help🤖 Archived on merge |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This comment was marked as low quality.
This comment was marked as low quality.
This comment was marked as resolved.
This comment was marked as resolved.
|
Caution Review failedPull request was closed or merged during review WalkthroughThis PR updates GitHub Actions workflow action versions across four workflows, adjusts Ruff and ty.toml rules (adds a Ruff ignore and removes two type-check rules), and adds a guard in markdown H2 extraction to skip tokens missing source-map data. ChangesGitHub Actions Workflow Dependency Updates
Tool Configuration Updates
Runtime Safety Improvement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…to 0 A `heading_open` token always carries a source map in practice, but `token.map` is typed `list[int] | None`. Defaulting a missing map to line 0 would make multiple H2 sections share the same start line and collapse their ranges. Skip such tokens instead, which is both safer and keeps ty happy via None-narrowing.
Summary
This PR updates GitHub Actions workflow dependencies to their latest versions and refines linting configurations to better match the project's needs.
Key Changes
GitHub Actions Updates
actions/upload-artifact(v6 → v7) andactions/download-artifact(v7 → v8), andactions/attest-build-provenance(v3 → v4)kjanat/github-labelmanager(v1 → v2)actions/deploy-pages(v4 → v5)actions/github-script(v8 → v9)Code Quality Improvements
token.mapbefore indexing, preventing crashes when the map is Nonebyte-string-type-annotationandfstring-type-annotation) that were causing unnecessary errorsPLW0717(too-many-try-statements) to ignore list to accommodate legitimate broad exception handling in psutil guard blocksNotable Details
The fix in
docs.pyensures robustness by handling the case wheretoken.mapmight beNone, defaulting to line 0 when unavailable. The linting configuration changes reflect a pragmatic approach to type checking and code style enforcement, removing rules that conflicted with legitimate code patterns in the project.Summary by CodeRabbit
Bug Fixes
Chores