-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: convert to Bun workspaces monorepo #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
746e9c9
0a65547
0702e15
942b132
28ee817
f1a6b4b
7f9d070
2e11c10
34b405d
eda57ac
2fce8c4
1b4abe0
c1d52ee
7ab02ec
400100a
75e5170
8aa03e8
c517f92
d1a336e
3a7406b
6deb385
6e65de9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -11,19 +11,23 @@ | |||||||||||||||||||||
| "wrap_guides": [100], | ||||||||||||||||||||||
| "file_types": { "Markdown": ["LICENSE"], "TypeScript": ["*.ts.tpl"] }, | ||||||||||||||||||||||
| "prettier": { "allowed": false }, | ||||||||||||||||||||||
| "formatter": [{ "language_server": { "name": "dprint" } }], | ||||||||||||||||||||||
| "formatter": [ | ||||||||||||||||||||||
| { "language_server": { "name": "dprint" } }, | ||||||||||||||||||||||
| // Fallback to the dprint CLI in case the lsp fucks up, which it does sometimes for some reason... | ||||||||||||||||||||||
| { "external": { "command": "dprint", "arguments": ["fmt", "--stdin", "{buffer_path}"] } } | ||||||||||||||||||||||
|
Comment on lines
+14
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: cat -n .zed/settings.json | head -50Repository: kjanat/dreamcli Length of output: 1989 Hoist the same colors on both masts, ye scallywag. Line 14 still calls bare ⚙️ Suggested fix "formatter": [
{ "language_server": { "name": "dprint" } },
// Fallback to the dprint CLI in case the lsp fucks up, which it does sometimes for some reason...
- { "external": { "command": "dprint", "arguments": ["fmt", "--stdin", "{buffer_path}"] } }
+ { "external": { "command": "bunx", "arguments": ["dprint", "fmt", "--stdin", "{buffer_path}"] } }
],📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||
| ], | ||||||||||||||||||||||
|
Comment on lines
+14
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial The formatter fallback chain be clever, though that comment be a wee bit salty. Havin' the LSP as primary with CLI fallback be a solid defensive pattern. However, that comment on line 13 be usin' rather... colorful language fer a config file that might get shared or copied. Consider softenin' it to somethin' like "which occasionally misbehaves" if ye want to keep things professional-like. That said, it's yer local editor config, so I won't be hoistin' the black flag over it. 🏴☠️ Optional: Tame the salty language "formatter": [
{ "language_server": { "name": "dprint" } },
- // Fallback to the dprint CLI in case the lsp fucks up, which it does sometimes for some reason...
+ // Fallback to the dprint CLI in case the LSP misbehaves
{ "external": { "command": "dprint", "arguments": ["fmt", "--stdin", "{buffer_path}"] } }
],📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||
| "languages": { | ||||||||||||||||||||||
| "JavaScript": { | ||||||||||||||||||||||
| "code_actions_on_format": { | ||||||||||||||||||||||
| "fixAll.biome": true, | ||||||||||||||||||||||
| "organizeImports.biome": true | ||||||||||||||||||||||
| "source.fixAll.biome": true, | ||||||||||||||||||||||
| "source.organizeImports.biome": true | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| "language_servers": ["vtsls", "tsgo", "biome", "deno"] | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| "TypeScript": { | ||||||||||||||||||||||
| "code_actions_on_format": { | ||||||||||||||||||||||
| "fixAll.biome": true, | ||||||||||||||||||||||
| "organizeImports.biome": true | ||||||||||||||||||||||
| "source.fixAll.biome": true, | ||||||||||||||||||||||
| "source.organizeImports.biome": true | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| "language_servers": ["vtsls", "tsgo", "biome", "deno", "vue-language-server"] | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: kjanat/dreamcli
Length of output: 170
Ruff configuration stands, but with shallow Python waters ahead
Aye, ye've got Python files in this ship (
skills/cli-creation/scripts/scaffold_cli.py), but 'tis but a single scaffolding script, not a full hold of Python cargo. Before ye weigh anchor with this ruff configuration, consider whether one wee helper script be worth the extra tooling weight. If this be the main Python file in sight, ye may be over-rigged for the haul.🤖 Prompt for AI Agents