Skip to content

feat: new card ordering system (universal context)#6678

Merged
dyersituations merged 8 commits intomainfrom
MP-2475
Mar 5, 2026
Merged

feat: new card ordering system (universal context)#6678
dyersituations merged 8 commits intomainfrom
MP-2475

Conversation

@tiarascoleman
Copy link
Copy Markdown
Contributor

@tiarascoleman tiarascoleman requested a review from a team February 25, 2026 16:16
@tiarascoleman tiarascoleman self-assigned this Feb 25, 2026
@tiarascoleman tiarascoleman added the b2c Sends B2C team a message in Slack on PR creation label Feb 25, 2026
@tiarascoleman tiarascoleman marked this pull request as draft February 25, 2026 16:24
Comment thread src/components/MyKiva/LendingStats.vue Outdated
Comment thread src/components/Contentful/JourneyCardCarousel.vue Outdated
Comment thread src/components/MyKiva/JourneyCardCarousel.vue
@tiarascoleman tiarascoleman marked this pull request as ready for review March 3, 2026 01:04
@tiarascoleman
Copy link
Copy Markdown
Contributor Author

tiarascoleman commented Mar 3, 2026

@kiva/b2c Thank you team, especially @cristhianDt for being patient in my solution; I believe it's ready! :)

Quick context: The added eight TODO comments are the remaining three cards (friendReferralCard, lendingTeamsCard, and kivaCard which are not yet implemented within carousel); these comments feature all associated code except for Line 320 in journeyCardCarousel- work/code still needs to be implemented there

Lastly, the journeyCardOrderingUtils.spec.js features two contexts: the current placeholder and the actual final verison- placeholder version (the context excluding the three last remaining cards) are 11 tests in total; final draft is 14!

Proud of this- thanks! :)

Comment thread src/util/journeyCardOrderingUtils.js Outdated
Comment thread src/components/MyKiva/JourneyCardCarousel.vue
Comment thread src/util/journeyCardOrderingUtils.js
Comment thread src/components/Contentful/JourneyCardCarousel.vue Outdated
Copy link
Copy Markdown
Collaborator

@dyersituations dyersituations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good in that they don't change existing carousel behavior.

@cristhianDt you can move forward with merging to your branch. Keep in mind that we likely need to adjust code in this PR, since the new version doesn't use the same type of carousel.

@dyersituations dyersituations merged commit bb3e7af into main Mar 5, 2026
5 checks passed
@dyersituations dyersituations deleted the MP-2475 branch March 5, 2026 16:46
kiva-robot added a commit that referenced this pull request Mar 5, 2026
## [3.60.0-rc.1](v3.59.0...v3.60.0-rc.1) (2026-03-05)

### 🎉 New Features

* add edit and delete actions to goal setting page ([9727f9f](9727f9f))
* add tests and tracking events for goal actions ([d4ab40b](d4ab40b))
* added back goalLoans amount ([aa70e8a](aa70e8a))
* fixed copy ([ecc8fcf](ecc8fcf))
* goals redirect to combo page fixed ([#6694](#6694)) ([787408e](787408e))
* new card ordering system (universal context) ([#6678](#6678)) ([bb3e7af](bb3e7af))
* rename loanTarget variable with an specific use ([598d150](598d150))
* revised copy (removed goalLoans from non-ID_SUPPORT_ALL contexts) ([7bf13cb](7bf13cb))
* revised progress ring copy fix (unit testing and additional contexts) ([1ac11c1](1ac11c1))
* revised titleTexts for US Entrepreneur context ([8f298b2](8f298b2))

### 🐛 Bugfixes

* [MP-2532] - Post lending next step overflows sometimes ([3efa37b](3efa37b))
* [MP-2537] - try to prevent some timing issues with vue re-render ([c93203d](c93203d))
* address ssr window undefined cases for cookie setting so default domain isn't used ([2e3ced5](2e3ced5))
* adjust mykiva and badges on ty ([#6699](#6699)) ([6f8176f](6f8176f))
* clarify comment about why we need to load preferences before doing an action ([fef5b30](fef5b30))
* clean up unnecesary emits and correctly name goal variables and methods ([3ae8861](3ae8861))
* conflicts ([5065c6a](5065c6a))
* conflicts and other app warnings ([84d9619](84d9619))
* consolidate one loading state for goal information and other to update goal options on category change ([ec40656](ec40656))
* do not refresh goal in delete method to keep goal visible ([f0acabc](f0acabc))
* edit goal copy ([67305dd](67305dd))
* ensure goal is updated before edit ([27b21fe](27b21fe))
* lint ([70681ef](70681ef))
* load current user preference to ensure removed goal is the correct one ([fad5763](fad5763))
* more ty page order changes and assorted cleanup ([#6709](#6709)) ([59bb182](59bb182))
* pencil icon alignment ([83879c7](83879c7))
* remove extraspace in comment ([0ffd959](0ffd959))
* remove support ([06089cc](06089cc))
* reorganize conditions ([1031fcc](1031fcc))
* reuse utility menu component and only show edit goal button in goal setting ([9742620](9742620))
* reverting goals redirect as not fixing ([#6707](#6707)) ([3b475c1](3b475c1))
* solve conflicts ([d86712e](d86712e))
* solve conflicts in goal progress ring ([7b215a5](7b215a5))
* update remove goal test ([e4f8e34](e4f8e34))
* update target only on edit ([7dc82f3](7dc82f3))
* update variable names and loading state ([2dcda49](2dcda49))
* use goal progress from composable in ring component instead of using goalLoans which is related to target ([e980402](e980402))

### 🔍 Tests

* add test for remove goal method ([d42bf96](d42bf96))

### 🧹 Chores

* [CP-2449] adjusting copy on MG sign up page ([55bf516](55bf516))
@kiva-robot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.60.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

kiva-robot added a commit that referenced this pull request Mar 6, 2026
## [3.60.0](v3.59.0...v3.60.0) (2026-03-06)

### 🎉 New Features

* add edit and delete actions to goal setting page ([9727f9f](9727f9f))
* add tests and tracking events for goal actions ([d4ab40b](d4ab40b))
* added back goalLoans amount ([aa70e8a](aa70e8a))
* fixed copy ([ecc8fcf](ecc8fcf))
* goals redirect to combo page fixed ([#6694](#6694)) ([787408e](787408e))
* new card ordering system (universal context) ([#6678](#6678)) ([bb3e7af](bb3e7af))
* rename loanTarget variable with an specific use ([598d150](598d150))
* revised copy (removed goalLoans from non-ID_SUPPORT_ALL contexts) ([7bf13cb](7bf13cb))
* revised progress ring copy fix (unit testing and additional contexts) ([1ac11c1](1ac11c1))
* revised titleTexts for US Entrepreneur context ([8f298b2](8f298b2))

### 🐛 Bugfixes

* [MP-2532] - Post lending next step overflows sometimes ([3efa37b](3efa37b))
* [MP-2537] - try to prevent some timing issues with vue re-render ([c93203d](c93203d))
* address ssr window undefined cases for cookie setting so default domain isn't used ([2e3ced5](2e3ced5))
* adjust mykiva and badges on ty ([#6699](#6699)) ([6f8176f](6f8176f))
* clarify comment about why we need to load preferences before doing an action ([fef5b30](fef5b30))
* clean up unnecesary emits and correctly name goal variables and methods ([3ae8861](3ae8861))
* conflicts ([5065c6a](5065c6a))
* conflicts and other app warnings ([84d9619](84d9619))
* consolidate one loading state for goal information and other to update goal options on category change ([ec40656](ec40656))
* do not refresh goal in delete method to keep goal visible ([f0acabc](f0acabc))
* edit goal copy ([67305dd](67305dd))
* ensure goal is updated before edit ([27b21fe](27b21fe))
* lint ([70681ef](70681ef))
* load current user preference to ensure removed goal is the correct one ([fad5763](fad5763))
* more ty page order changes and assorted cleanup ([#6709](#6709)) ([59bb182](59bb182))
* pencil icon alignment ([83879c7](83879c7))
* remove extraspace in comment ([0ffd959](0ffd959))
* remove support ([06089cc](06089cc))
* reorganize conditions ([1031fcc](1031fcc))
* reuse utility menu component and only show edit goal button in goal setting ([9742620](9742620))
* reverting goals redirect as not fixing ([#6707](#6707)) ([3b475c1](3b475c1))
* solve conflicts ([d86712e](d86712e))
* solve conflicts in goal progress ring ([7b215a5](7b215a5))
* update remove goal test ([e4f8e34](e4f8e34))
* update target only on edit ([7dc82f3](7dc82f3))
* update variable names and loading state ([2dcda49](2dcda49))
* use goal progress from composable in ring component instead of using goalLoans which is related to target ([e980402](e980402))

### 🔍 Tests

* add test for remove goal method ([d42bf96](d42bf96))

### 🧹 Chores

* [CP-2449] adjusting copy on MG sign up page ([55bf516](55bf516))
* **release:** 3.60.0-rc.1 [skip ci] ([b962b60](b962b60)), closes [#6694](#6694) [#6678](#6678) [#6699](#6699) [#6709](#6709) [#6707](#6707)
@kiva-robot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.60.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b2c Sends B2C team a message in Slack on PR creation released on @staging released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants