Add manifest URL support for centralized rule/task management#138
Merged
Conversation
- Use getter.GetFile() to download manifest files (not directories) - Parse manifest file to get search paths (one per line) - Download manifest before downloading other directories - Add comprehensive test for manifest file functionality - All existing tests pass Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
- Filter out empty lines from manifest file - Use fmt.Sprintf for better readability in tests - Add test for manifest files with empty lines - Add fmt import to integration_test.go Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add manifest URL support to CLI
Add manifest URL support for centralized rule/task management
Dec 4, 2025
alexec
reviewed
Dec 4, 2025
| paths = append(paths, scanner.Text()) | ||
| line := scanner.Text() | ||
| // Skip empty lines | ||
| if line != "" { |
Blank lines are not allowed in manifest files per the format specification, so we don't need to filter them out. Removed the empty line check and the associated test. Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
alexec
approved these changes
Dec 4, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for loading rules and tasks from remote locations specified in a manifest file, enabling centralized management of coding standards across projects. The key improvement is moving manifest parsing to occur before downloading remote directories, ensuring paths from the manifest are properly included in the download phase.
- Manifest file is now parsed before downloading remote directories (not after)
- Uses
getter.GetFile()instead ofgetter.Get()for single-file manifest downloads - Includes integration test validating manifest-based rule/task loading
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/codingcontext/context.go | Reorders manifest parsing before remote downloads; switches to GetFile() for manifest retrieval |
| integration_test.go | Adds integration test for manifest file functionality with local and remote rules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables loading rules and tasks from multiple remote locations via a manifest file, supporting centralized management of coding standards and task definitions across projects.
Changes
getter.GetFile()for manifest downloads: Downloads single manifest file correctly (not a directory structure)Usage
Manifest supports all go-getter protocols:
http://,https://,git::,s3::,file://.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.