Tag type discrimination POC#97
Open
stackoverfloweth wants to merge 1 commit intomainfrom
Open
Conversation
… setQueryData handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define
kindto discriminate tags, require each kind is satisfied by setQueryData handlerTags can be defined without
kind, defaults to"default". Kind doesn't have to be unique. You can have 30 tags with "default" kind but as soon as you pass 2 tags with kind "default" in that have conflicting data types, yoursetQueryDatais going to correctly provide and expectnever.Note
This awkward syntax is a bit of a downside. Because of how TS works, we basically have to pass in the value twice, once in the generic and again at runtime. If this PR ends up being a good direction, we can talk through alt syntax that makes this less awkward
When you call
setQueryDataon a single tag it's a simple callbackWhen you call
setQueryDatawith multiple tags with the samekindor different kinds but same underlying data type, it's also a simple callbackWhen you call
setQueryDatawith multiple tags with different kinds, you MUST define a handler for each kind