chore: reword history comments to clear the lint gate on main - #9802
Conversation
Reword the 75 comment and docstring markers that current main added beyond the recorded baseline. Keep each invariant in present tense and leave executable behavior unchanged.
|
Intent: Restore the comment-history ratchet on current main by rewording only the inherited markers above each file's recorded baseline. |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The heal pays down today's drift but leaves open the gate hole that let ten merged commits grow past baseline, so the red will recur. Watch
Suggestions
[DESIGN-REVIEWED] 8ad8eb9 |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of The root-cause mechanism is confirmed: First-Principles-Verdict: PASS Two rewrites assert current behavior instead of trimming a ref — confirm "there is no text-path fence" and "lost, with no restart notice" are still true. What this change shipsInventory (6 items) — 6 justifiedIntent: FIX — reword the 73 history-narration markers main accumulated above the ratchet baseline, so unrelated PRs stop inheriting a red
Every hunk removes a marker [FIRST-PRINCIPLES-REVIEWED] 8ad8eb9 |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Provenance and local gate evidence
The first three landed around the gate's baseline capture and were absent from its source snapshot. The others landed after the gate. Local verdicts on the final diff: |
|
self-added: no
|
|
self-added: no
|
Problem / Motivation
Main is above its history-narration baseline in 25 files. A PR that touches one of those files gets a red
Backend Lint & Type Check (3.12)result even when it adds no matching comment.Why it matters
Unrelated PRs are blocked by comments already on
main. Fixing the same inherited lines in each PR would repeat work and hide the real cause.What changed (motivation → approach → change)
The 73 excess markers state what the code does in present tense. The recorded baseline does not move. No executable code changes.
Tests
The comment-history gate passes for the PR diff and the whole tree.
python3 scripts/check_comment_history.py --testpython3 scripts/check_comment_history.pyRATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_comment_history.pypytest -n0on every touched test path: 2,710 passed, 5 skippedManual verification
N/A — the whole-tree gate proves every count is at or below its recorded baseline.
Why no screenshot: Only comments and docstrings change. No rendered surface changes.
Related Issues
no linked issue: this repairs inherited lint failures seen by open PRs.
Pattern harvest
Rule candidate: lint
Pattern: Ratchet checks on protected-base pushes must inspect the integrated whole tree, not an empty base-to-HEAD diff.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)