chore(comments): drop the history narration main outgrew its baseline on - #9364
Conversation
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Correct unblocker: rewording the drifted narration and lowering the ratchet fixes the gate failure without touching behavior or weakening any pin. Suggestions
[DESIGN-REVIEWED] 87ea82f |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of All verification is done. The gate script, code-style rule, and audit workflow confirm the description's mechanism; I counted the removed spans in the patch (10 in First-Principles-Verdict: PASS Verify whole-tree scope once: run What this change shipsInventory (3 items)Intent: unblock PRs failing the comment-history gate on drift they never wrote, by removing main's over-baseline narration. FIX.
The defect is derived, not asserted: the gate's grown-count verdict ( [FIRST-PRINCIPLES-REVIEWED] 87ea82f |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
…aseline on The comment-history gate scans only the files a diff touches, so the seven narrated spans that landed in chat_runner.py (109 vs a baseline of 103) and context.py (12 vs 11) went unnoticed on main until a PR touched either file -- and then failed that PR on lines it never wrote. Reword the newest spans to present tense with no issue numbers, bringing both files back under their baseline entries; no behavior change.
4dfaa84 to
3479a40
Compare
Summary
scripts/check_comment_history.pyonly scans the files a diff touches, so the change-history narration that landed on main insrc/kiro_crew/dashboard/chat_runner.py(109 spans against a baseline entry of 103) andsrc/kiro_crew/context.py(12 against 11) went unnoticed on main's own pushes — and then failed any PR that touches either file withhistory narration in comments grew from 103 to 109on lines that PR never wrote (first hit: #8862, round 17).This rewords the newest spans (the
issue #6189/issue #8132references andpreviously/Until #6189phrasing in the redaction-notice docstrings ofchat_runner.py; theused to be appendedcomment incontext.py) to present-tense statements of current behavior with no issue numbers, perdocs/system-specs/common/code-style.md.--write-baselinethen lowerschat_runner.pyto 99 (the ratchet only ever lowers). No behavior change; comments and one JSON baseline entry only.Verification
python3 scripts/check_comment_history.pyon this branch:comment-history gate passed.main(fd6684b40) measured with the gate's ownviolations_in_source:chat_runner.py109 vs baseline 103,context.py12 vs 11 — the drift this PR removes.scripts/check_black_formatting.pyandflake8on the two files: clean.Unblocks #8862 (and any other PR touching these two files).