fix(i18n): drop the dead pages.chatPage.dismiss_upload_error key

[bolichen97]

Summary

main is red on Frontend Tests (3) since #8859: src/i18n/deadKeys.test.ts counts 30 unreferenced catalog keys against a baseline of 29. The new dead key is pages.chatPage.dismiss_upload_error — #8859 replaced the chat pane's hand-rolled upload-error strip (and its dismiss button, whose aria-label read this key) with ErrorNotice, which carries its own dismiss control, but the key stayed in every catalog.

This removes the key from the 13 catalogs (12 authored + regenerated en-XA). BASELINE is unchanged at 29. No UI change.

Verification

npx vitest run src/i18n — 42 files / 663 tests passed (deadKeys, catalogParity, keyReference, pluralKeys, changedValueQa included).

Every open PR rebased onto current main fails the same shard until this lands (e.g. #8943).

[github-actions]

Design Review (Fable 5) — ✅ PASS

Design-level review of 02fa7c2011f07f97ab60f28939ebe75da56ed255 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Pure dead-key deletion across all thirteen catalogs, restoring the dead-key ratchet to its baseline; no code references remain and no design surface changes.

[DESIGN-REVIEWED] 02fa7c2

[github-actions]

UX Review (Fable 5) — ✅ PASS

UX-level review of 02fa7c2011f07f97ab60f28939ebe75da56ed255 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Deletes one unreferenced i18n key from 13 catalogs; dismiss_upload_error has zero references in website/src, so no rendered string, control, or state changes.

[UX-REVIEWED] 02fa7c2

[github-actions]

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of 02fa7c2011f07f97ab60f28939ebe75da56ed255 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

All verification checks out: the key is referenced nowhere in the repo (grep for dismiss_upload_error across the whole checkout: 0 hits outside the diff's deletions), all 13 non-manual catalogs are covered plus en.manual.json never carried the key, and deadKeys.test.ts:106 pins the count exactly to BASELINE = 29 — so main was red at 30 and this deletion restores exactly 29 with no baseline edit. This is a pure subtraction that unwedges a red build, which the contract treats as derived by definition.

First-Principles-Verdict: PASS

A pure deletion that unwedges the red deadKeys shard: one orphaned key removed from every catalog, baseline untouched, nothing rides along.

What this change ships

Intent: turn Frontend Tests (3) green again by deleting the catalog key #8859 orphaned. This is a FIX.

1. The unused "Dismiss upload error" string is deleted from all 13 locale catalogs — justified

The claim checks out mechanically: grep for dismiss_upload_error across the repo finds zero references (the ErrorNotice replacement in #8859 carries its own dismiss label), en.manual.json never held the key, and deadKeys.test.ts pins the dead count to exactly BASELINE = 29 in both directions, so this single deletion is the precise fix — no baseline bump, no rider, no smaller version exists. The 29 remaining dead keys are pre-existing debt the ratchet already tracks; they are not siblings of this cause (#8859's removal of the strip) and belong to no in-scope fix.

[FIRST-PRINCIPLES-REVIEWED] 02fa7c2

[github-actions]

Opus 4.8 Review — ✅ no blocking findings

Reviewed 02fa7c2011f07f97ab60f28939ebe75da56ed255 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 02fa7c2

Verdict parsed from the review's SHA-scoped output markers for commit 02fa7c2011f07f97ab60f28939ebe75da56ed255.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 02fa7c2011f07f97ab60f28939ebe75da56ed255: <one-sentence reason>

[github-actions]

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 02fa7c2011f07f97ab60f28939ebe75da56ed255 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 02fa7c2

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 02fa7c2011f07f97ab60f28939ebe75da56ed255: <one-sentence reason>