Skip to content

docs(ec2): fix the ffmpeg ~/.local/bin hint in the EC2 guide (#8897) - #8944

Merged
bolichen97 merged 1 commit into
mainfrom
fix-ffmpeg-doctor-hint
Sep 8, 2026
Merged

docs(ec2): fix the ffmpeg ~/.local/bin hint in the EC2 guide (#8897)#8944
bolichen97 merged 1 commit into
mainfrom
fix-ffmpeg-doctor-hint

Conversation

@bolichen97

@bolichen97 bolichen97 commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Addresses the documentation surface of #8897 that PR #8937 does not cover.

Why this is separate from #8937

#8937 is review-ready and CI-green, and it fixes the doctor hint in src/kiro_crew/cli_doctor.py plus the tests. It does not touch the second surface the issue flags. This PR is now scoped to that single missing piece so the two don't overlap. Its net diff is one file.

Change

  • docs/guides/remote-crew-on-ec2.md (line ~137): the ffmpeg: not found note no longer tells users to drop a static build into ~/.local/bin and claim auto-detection (a directory the resolver never searches). It now says to install ffmpeg into /usr/local/bin (a location the resolver searches; not in the AL2023 repos), or fetch a decoder from the dashboard Speech-to-Text card (Settings > Voice, then Download now) via the POST /api/stt/ffmpeg/download path added in feat(stt): fetch the pinned ffmpeg decoder for source installs #8427.

Tests

N/A -- doc-only change, no code touched.

Manual verification

N/A -- unit coverage sufficient; verified scripts/docs-lint.sh passes clean on the changed file.

Note

If #8937 merges first, this remains a clean, non-conflicting doc-only follow-up. If a maintainer prefers a single PR, the EC2 guide change can instead be cherry-picked onto #8937 and this PR closed.

Closes #8897

@bolichen97
bolichen97 requested a review from a team as a code owner September 6, 2026 08:17
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 6, 2026
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of b2ee5bc0fcce5c27f83bd19c8cc1491002726c0d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Corrects a doc hint the resolver deliberately contradicts — ~/.local/bin was removed from the candidate list as a security decision (transcribe.py:92) — and both replacement remedies verifiably exist.

[DESIGN-REVIEWED] b2ee5bc

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 6, 2026
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed b2ee5bc0fcce5c27f83bd19c8cc1491002726c0d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b2ee5bc

Verdict parsed from the review's SHA-scoped output markers for commit b2ee5bc0fcce5c27f83bd19c8cc1491002726c0d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable b2ee5bc0fcce5c27f83bd19c8cc1491002726c0d: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of b2ee5bc0fcce5c27f83bd19c8cc1491002726c0d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b2ee5bc

False positive or not applicable? A repository writer can comment:
/ai-review override gpt b2ee5bc0fcce5c27f83bd19c8cc1491002726c0d: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ⏭️ skipped

Revision b2ee5bc0fcce5c27f83bd19c8cc1491002726c0d ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@bolichen97
bolichen97 force-pushed the fix-ffmpeg-doctor-hint branch from 0e8b067 to 31efa13 Compare September 6, 2026 08:48
@bolichen97 bolichen97 changed the title fix(doctor): name resolver-searched ffmpeg locations, not ~/.local/bin (#8897) docs(ec2): fix the ffmpeg ~/.local/bin hint in the EC2 guide (#8897) Sep 6, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 6, 2026
Closes #8897

Co-authored-by: Kiro Crew <noreply@kiro.dev>
@bolichen97
bolichen97 force-pushed the fix-ffmpeg-doctor-hint branch from 31efa13 to b2ee5bc Compare September 8, 2026 04:24
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 8, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) September 8, 2026 06:40
@bolichen97
bolichen97 merged commit 3fd967b into main Sep 8, 2026
67 of 73 checks passed
@bolichen97
bolichen97 deleted the fix-ffmpeg-doctor-hint branch September 8, 2026 06:40
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doctor: Linux ffmpeg fix names ~/.local/bin, which is never searched

2 participants