test(settings): point the RemoteCrewPanel diagnosis helper at the ErrorNotice

[CrysisDeu]

Problem / Motivation

Main is red on four RemoteCrewPanel.test.tsx cases (agent hand-off from the diagnosis note): every open PR's merge ref fails them (seen on #8816). Two settings batches crossed: #8749 (settings-2) moved the diagnosis note to the shared ErrorNotice (role="alert", testId="remote-crew-diagnosis"), then #8729 (settings-1) landed a test helper written against the old role="status" box, so closest('[role="status"]') returns null and within(null) throws.

What changed

One helper in the test: select the note by its remote-crew-diagnosis testId instead of walking up to a role="status" ancestor that no longer exists. No product code touched.

Tests

Per the owner's standing instruction no suite was run locally; CI verifies. Unblocker for #8816 and any other PR whose merge ref includes both #8729 and #8749.

Related Issues

Cross-merge of #8729 and #8749. Unblocks #8816.

Checklist

• One commit, Conventional Commits title
• Existing tests pass (CI)

[github-actions]

UX Review (Fable 5) — ✅ PASS

UX-level review of c5cfc063b8cd545d6bce0b780c3e62ec5a5169b1 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Test-only change: a selector fix in RemoteCrewPanel.test.tsx; no user-facing surface, string, or pixel is touched.

[UX-REVIEWED] c5cfc06

[github-actions]

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of c5cfc063b8cd545d6bce0b780c3e62ec5a5169b1 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c5cfc06

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c5cfc063b8cd545d6bce0b780c3e62ec5a5169b1: <one-sentence reason>

[github-actions]

Design Review (Fable 5) — ✅ PASS

Design-level review of c5cfc063b8cd545d6bce0b780c3e62ec5a5169b1 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Verified: the component (website/src/pages/settings/RemoteCrewPanel.tsx:1188) does render the diagnosis note as an ErrorNotice with testId="remote-crew-diagnosis", matching the PR's claim, and a sibling test file already selects it by that same testId. The fix is a minimal, test-only repair of a cross-merge breakage between two settings batches, aimed at the actual root cause (the helper anchored on a role="status" ancestor that no longer exists). No product code touched, no contract or reversibility concerns.

Design-Verdict: PASS

Test-only cross-merge repair, verified against the component: the diagnosis note really is the ErrorNotice with that testId; right shape, right size.

[DESIGN-REVIEWED] c5cfc06

[github-actions]

Opus 4.8 Review — ✅ no blocking findings

Reviewed c5cfc063b8cd545d6bce0b780c3e62ec5a5169b1 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c5cfc06

Verdict parsed from the review's SHA-scoped output markers for commit c5cfc063b8cd545d6bce0b780c3e62ec5a5169b1.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c5cfc063b8cd545d6bce0b780c3e62ec5a5169b1: <one-sentence reason>

[NicholasRBowers]

Tier 1 auto-approve: test (1 file). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, SAST annotations clean, security checklist all-NO, AI reviewers green. Category: test-only change re-pointing the RemoteCrewPanel diagnosis helper at the ErrorNotice testid after #8749 moved the note off role=status.