Skip to content

docs(rfc): record the chat-core extraction RFC and its progress - #8690

Merged
chenmingwei23 merged 1 commit into
mainfrom
docs/rfc-chat-core-extraction
Sep 5, 2026
Merged

docs(rfc): record the chat-core extraction RFC and its progress#8690
chenmingwei23 merged 1 commit into
mainfrom
docs/rfc-chat-core-extraction

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Problem / Motivation

The chat-core extraction RFC has lived only as a dashboard artifact since 2026-08-22, while P1 (#5128) and the first P2 slice (#5909) merged and three more slices (#8599, #8655, #8689) went into review. Reviewers on those PRs have had to be pointed at an out-of-repo document.

What changed

  • docs/request-for-change/rfc-chat-core-extraction.md: the RFC as reviewed, plus the 2026-09-05 inventory correction (the send sites beyond the five surfaces), the ratified §4.1 host-only decision with its tracking issue chat-core P3: store-free seam for ChatInput so ChatEmbed no longer requires the host store #8651, the landed shapes of each layer, and a §4.2 per-PR progress table with the review follow-ups that are recorded but not yet scheduled.
  • docs/request-for-change/README.md: index row with status partial, stating what is actually on main, verified at 8ed028b0b (registry + parity test present; sendTurn present with ChatPane as its only production caller; SideChat on ChatInput; ChatEmbed still a bare <input>; ChatPage still 29 role === branches).

Docs only. No code, no strings.

Why no screenshot: documentation-only change.

Checklist

  • Single commit
  • Index row follows the README's convention (status + what is on main + audited commit)

Contribution License Agreement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@CrysisDeu
CrysisDeu requested a review from a team as a code owner September 5, 2026 07:35
@CrysisDeu
CrysisDeu requested a review from smeyffret September 5, 2026 07:35
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed 44e351dbc13229ba894e17ed83802da68ff83bf0 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 44e351d

Verdict parsed from the review's SHA-scoped output markers for commit 44e351dbc13229ba894e17ed83802da68ff83bf0.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 44e351dbc13229ba894e17ed83802da68ff83bf0: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 44e351dbc13229ba894e17ed83802da68ff83bf0 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Docs-only RFC recording that follows the established request-for-change/ convention exactly: indexed, status-stamped, and audit-pinned to a commit; no design-level concerns.

[DESIGN-REVIEWED] 44e351d

@github-actions

github-actions Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 44e351dbc13229ba894e17ed83802da68ff83bf0 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 44e351d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 44e351dbc13229ba894e17ed83802da68ff83bf0: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 5, 2026
@CrysisDeu CrysisDeu mentioned this pull request Sep 5, 2026
Open
5 tasks
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 5, 2026
@CrysisDeu CrysisDeu mentioned this pull request Sep 5, 2026
Merged
4 tasks
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 5, 2026
@CrysisDeu
CrysisDeu force-pushed the docs/rfc-chat-core-extraction branch from 313b1b4 to bcc8cf1 Compare September 5, 2026 09:58
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 5, 2026
@CrysisDeu CrysisDeu mentioned this pull request Sep 5, 2026
Merged
4 tasks
@CrysisDeu
docs(rfc): record the chat-core extraction RFC and its progress
44e351d 
The RFC has lived as a dashboard artifact since 2026-08-22 while P1 and
the first P2 slice merged and three more P2/P3 slices went into review.
Commit it beside the other RFCs, with the 2026-09-05 inventory
correction, the ratified §4.1 host-only decision (#8651), and a per-PR
progress table, and add its index row audited at 8ed028b.
@CrysisDeu
CrysisDeu force-pushed the docs/rfc-chat-core-extraction branch from bcc8cf1 to 44e351d Compare September 5, 2026 13:26
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 5, 2026
chenmingwei23
chenmingwei23 approved these changes Sep 5, 2026
View reviewed changes

@chenmingwei23 chenmingwei23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: checks green at head, readiness passed, no blocking reviewer verdict outstanding.

@chenmingwei23
chenmingwei23 merged commit 0770ce7 into main Sep 5, 2026
65 checks passed
@chenmingwei23
chenmingwei23 deleted the docs/rfc-chat-core-extraction branch September 5, 2026 23:13
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 5, 2026
This was referenced Sep 5, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenmingwei23 chenmingwei23 chenmingwei23 approved these changes
@smeyffret smeyffret Awaiting requested review from smeyffret smeyffret is a code owner automatically assigned from kirodotdev/kirocrew-team

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CrysisDeu @chenmingwei23