Skip to content

ci: re-measure the i18n runtime chunk budget at 740 KB - #8411

Closed
CrysisDeu wants to merge 1 commit into
mainfrom
ci/bundle-budget-t-780
Closed

ci: re-measure the i18n runtime chunk budget at 740 KB#8411
CrysisDeu wants to merge 1 commit into
mainfrom
ci/bundle-budget-t-780

Conversation

@CrysisDeu

Copy link
Copy Markdown
Collaborator

Problem / Motivation

Every PR rebased onto current main fails Bundle Size Gate with:

FAIL assets/t-Cr8LfdHT.js: 740.0 KB exceeds its 740.0 KB budget by 4 B (chunk 't')

The PRs' own diffs do not touch the chunk. #8286 (two workflow prompt bullets and one docs paragraph), #8292's fork-review fix and the nested-submenus fix all show the same red on the same head window (08:40–08:43 UTC), while PRs whose merge ref predates 01:24 UTC pass.

Why it matters

The gate is red on main's own content, so it blocks unrelated PRs and trains people to rerun or override it — the same shape as the 2026-08-27 stale-headroom incident recorded in the file's own comment. Until the ceiling moves, nothing that touches main can go green.

What changed (motivation → approach → change)

Three commits landed on main in a seven-minute window (4e5398dd2 agent-picker roster failure, de19df867 inline crew schedule, 390ac8d2f aws-control shared notice), each adding English strings to the t runtime catalog. Individually each fit under the 740 KB ceiling; together they put the chunk 4 B over. The t budget is documented as "grows a little with every translated string, which is expected and fine; what this ceiling catches is a NEW library or surface" — so the right move is to re-measure and move the ceiling, not to shrink strings.

One-line change in website/scripts/check-bundle-size.mjs: t: 740 * KBt: 780 * KB, with the measurement note updated to 740 KB on 2026-09-04 and the three contributing merges named in the comment. ~5% headroom, matching the all entry's convention.

Tests

N/A — a budget constant; the gate itself is the test. CI's Bundle Size Gate on this PR verifies the new ceiling holds for the current chunk.

Manual verification

Read the failing job log on #8286 (job 100965157938) for the exact overage; confirmed via gh run view that sibling PRs on the same main window fail the same job and that main's own ci.yml skips the gate (PR-only), so main cannot show the red itself.

Related Issues

no linked issue: main-inherited CI unblocker, no tracked issue.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Three locale-adding merges (4e5398d, de19df8, 390ac8d) put the 't' chunk 4 B over its 740 KB ceiling, so Bundle Size Gate is red on every PR rebased onto main. Move the ceiling to 780 KB with the measurement note updated, the same stale-headroom remedy as 2026-08-27.
@CrysisDeu
CrysisDeu requested a review from a team as a code owner September 4, 2026 08:50
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — ✅ PASS

UX-level review of f278a8d9cd3aa864490a7b61556103716318a63d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

No user-facing surface changed — this is a CI bundle-budget comment and threshold bump in a build script; nothing a user sees or touches.

[UX-REVIEWED] f278a8d

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed f278a8d9cd3aa864490a7b61556103716318a63d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f278a8d

Verdict parsed from the review's SHA-scoped output markers for commit f278a8d9cd3aa864490a7b61556103716318a63d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f278a8d9cd3aa864490a7b61556103716318a63d: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of f278a8d9cd3aa864490a7b61556103716318a63d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

A measured, convention-following ceiling move for documented catalog growth the entry explicitly deems expected — the right fix, at the right layer.

The diff does exactly what the file's own contract demands: justifies the raise, names the contributing merges, keeps the ~5% headroom convention (740 KB measured → 780 KB), and updates the comment in place. String growth is the one cause this entry's docs say should never trip the gate ("grows a little with every translated string, which is expected and fine"), so moving the ceiling — not shrinking strings — is the root-cause-correct response.

Suggestions

  • Second identical stale-headroom red in 8 days (08-27, 09-04); a follow-up that warns (not fails) when a chunk sits within ~1% of its budget would let the ceiling move before main blocks unrelated PRs.

[DESIGN-REVIEWED] f278a8d

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of f278a8d9cd3aa864490a7b61556103716318a63d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f278a8d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f278a8d9cd3aa864490a7b61556103716318a63d: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 4, 2026
@NicholasRBowers
NicholasRBowers enabled auto-merge (squash) September 4, 2026 09:30

@NicholasRBowers NicholasRBowers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: chore/build tooling (1 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, SAST annotations clean, security checklist all-NO, AI reviewers green. Category: single-file CI bundle-budget re-measure in website/scripts/check-bundle-size.mjs (t chunk ceiling 740->780 KB), no runtime impact. Note: edits the same budget line as #8412; whichever merges first conflicts the other, which branch protection resolves.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 4, 2026
@CrysisDeu

Copy link
Copy Markdown
Collaborator Author

Superseded by #8412 (merged 434ff7c), which re-measured the same t ceiling to 777 KB. Closing as redundant.

@CrysisDeu CrysisDeu closed this Sep 4, 2026
auto-merge was automatically disabled September 4, 2026 09:35

Pull request was closed

@CrysisDeu
CrysisDeu deleted the ci/bundle-budget-t-780 branch September 4, 2026 09:35
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants