Skip to content

fix(channels): remove duplicate Modal import - #6916

Merged
buluoray merged 1 commit into
kirodotdev:mainfrom
bolichen97:fix/channel-modal-duplicate-import
Aug 30, 2026
Merged

fix(channels): remove duplicate Modal import#6916
buluoray merged 1 commit into
kirodotdev:mainfrom
bolichen97:fix/channel-modal-duplicate-import

Conversation

@bolichen97

Copy link
Copy Markdown
Collaborator

Problem / Motivation

Main no longer typechecks after #5570 added a second default import for Modal in ChannelPage. The same symbol was already imported by #6796, so TypeScript fails deterministically with TS2300 at lines 2 and 16.

Why it matters

This is a main-branch compile regression and makes unrelated PRs fail the frontend typecheck gate.

What changed

Remove only the later duplicate import. The original shared Modal import and all Channel behavior remain unchanged.

Tests

  • red-before: npm run typecheck fails deterministically with duplicate identifier Modal
  • fixed final main snapshot: npm run typecheck passes
  • ChannelPage coverage, clear-context, IME, menu-keyboard, and narrow-layout suites: 106/106 passed
  • changed-file ESLint and diff checks pass
  • audited all open PRs: the only exact-file overlap, fix(channels): per-command trust tiers on approval cards (#5231) #5248, changes approval trust tiers and does not own this import regression

No retries, sleeps, timeout changes, warning filters, or assertion changes were added.

Screenshot evidence

Why no screenshot: This removes a duplicate import only; runtime UI output is unchanged.

PR kirodotdev#5570 added a second import for the shared modal even though ChannelPage already imported it after kirodotdev#6796. Keep the existing import and remove only the duplicate so the merged main snapshot typechecks again.
@bolichen97
bolichen97 requested a review from a team August 30, 2026 04:54
@bolichen97
bolichen97 requested a review from a team as a code owner August 30, 2026 04:54
@bolichen97
bolichen97 requested a review from smeyffret August 30, 2026 04:54
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Aug 30, 2026
@buluoray
buluoray enabled auto-merge (squash) August 30, 2026 05:07
@buluoray
buluoray merged commit d7b7d65 into kirodotdev:main Aug 30, 2026
59 of 64 checks passed
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants