fix(test): shape mock config to prevent 500 in slot create test - #6526
fix(test): shape mock config to prevent 500 in slot create test#6526bolichen97 wants to merge 1 commit into
Conversation
…arest_folder_project
The bare MagicMock() config caused a 500 error because:
- mock_cfg.default_agent was a truthy MagicMock, triggering the
resolve_agent_bindings path
- mock_cfg.agents was a non-iterable MagicMock, causing StopIteration
- MagicMock attributes on the slot were not JSON-serializable when
suspend_slots_push() exited and broadcast slot data
Fix: set mock_cfg.agents = {} (falsy, skips resolve path) and
mock_cfg.default_agent = "" (falsy, skips agent assignment).
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Two-line mock shaping matches the handler's real falsy-config semantics; verified against the Suggestions
[DESIGN-REVIEWED] 210fa99 |
Closing as duplicate of #6533 which applies the same fix with full local verification.