Skip to content

docs(remote): explain local gateway toggle prerequisite - #4259

Merged
bolichen97 merged 2 commits into
kirodotdev:mainfrom
adiarora06:codex/remote-gateway-toggle-docs
Sep 10, 2026
Merged

docs(remote): explain local gateway toggle prerequisite#4259
bolichen97 merged 2 commits into
kirodotdev:mainfrom
adiarora06:codex/remote-gateway-toggle-docs

Conversation

@adiarora06

@adiarora06 adiarora06 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

The persistent SSH tunnel guide did not explain that the desktop app's supervised local gateway must be disabled when the app should act only as a client of the tunnel.

Why it matters

Without the prerequisite and launch order, users can accidentally run a competing local gateway and misdiagnose tunnel connectivity or connect through the wrong mechanism.

What changed (motivation → approach → change)

The guide now documents the required launch order and local-gateway toggle, clarifies that the toggle does not create or supervise the tunnel, and distinguishes the Connected Instance feature from the SSH-tunnel workflow.

Tests

  • ./scripts/docs-lint.sh (212 Markdown files scanned; all checks passed)

Manual verification

N/A — this is a documentation-only clarification and the documentation lint passes.

Related Issues

Addresses #3810

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

The repository's CLA placeholder remains pending OSPO wording.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Aug 18, 2026
@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

27 similar comments
@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@bolichen97

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@bolichen97

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@bolichen97

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@bolichen97

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@bolichen97

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@bolichen97

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@bolichen97

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@bolichen97

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@adiarora06
adiarora06 force-pushed the codex/remote-gateway-toggle-docs branch from cbc4d1b to 79d8647 Compare August 30, 2026 17:25
@dwu96

dwu96 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

1 similar comment
@iamwhatever

Copy link
Copy Markdown
Collaborator

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@adiarora06
adiarora06 marked this pull request as ready for review September 2, 2026 21:38
@adiarora06
adiarora06 requested a review from a team as a code owner September 2, 2026 21:38
@adiarora06
adiarora06 requested a review from CrysisDeu September 2, 2026 21:38
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 2, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Opus 4.8 Review (fork) — ✅ no blocking findings

Reviewed 161b7ee2403418a8131791c6b6e219fd044fca9b via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 161b7ee

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed 161b7ee2403418a8131791c6b6e219fd044fca9b via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 161b7ee

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of 161b7ee2403418a8131791c6b6e219fd044fca9b via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

A real footgun (competing supervised gateway on port 5476), fixed at the right place; every factual claim checks out against the toggle, quit, and Instances code.

The added prose matches the base tree: the Run a local gateway switch and its off-path port resolution exist in website/electron/main.js:106 (resolvePort targets an already-running gateway when the toggle is off), before-quit tears down the supervised gateway so the quit-first launch order is accurate, and the Instances distinction matches docs/system-specs/modules/instances.md (hub-supervised tunnels on allocated loopback ports). No design-level concerns.

[DESIGN-REVIEWED] 161b7ee

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 3, 2026
@bolichen97

Copy link
Copy Markdown
Collaborator

Open PR relationship audit

This is a consolidated, point-in-time code-level audit note. It compares complete merge-base diffs and current/merged code; it does not treat a shared topic as duplication or partial coverage as completion.

Relationship findings

  • This PR is PARTIALLY_COVERED with PR #2917. Coverage is explicitly incomplete; this finding is not a completion or closure claim. Recommended action for PR #4259: CONTINUE_DEVELOPMENT. The merged feature supplies the toggle and generic help text but not the prerequisite documentation this PR adds, so the docs gap is real and unclosed; the PR's own content defects (launch order, paragraph placement) still need a fix before merge. Files: website/electron/local-gateway.js.

No PR, Issue, label, branch, or review state was changed by the relationship-note portion of this audit.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Sep 8, 2026
@bolichen97

Copy link
Copy Markdown
Collaborator

@adiarora06 Thanks for this. The gap is real and still unclosed on main, so this should land rather than be closed. #2917 shipped the toggle itself plus one line of in-UI help text, which covers client-only mode and "takes effect next launch". It does not state the prerequisite that something must already answer on port 5476, the launch order, that the toggle neither creates nor supervises a tunnel, or that a connected Instances entry does not satisfy it. None of that prose exists anywhere under docs/ on main.

Two notes, audited at 79d8647 and re-checked against your current head.

Your latest revision already fixed the two content problems the audit found. The paragraph now sits before the "A ready-made plist is at ...:" sentence instead of splitting it from the code block that colon introduces, and the launch order now disables the toggle and quits the app before starting the tunnel, which is correct because a still-enabled local gateway holds port 5476. Nothing further needed there.

Please rebase before we merge. The branch is still on merge base 3af243d and roughly 1224 commits behind. docs/guides/remote-and-mobile.md has been reworked several times since, in #7780, #7999, #8617, #8208 and #8905. None of those touch this prerequisite, so the rebase should be textual only.

One scope point: the body says this addresses #3810, but that issue's primary asks are help text under the toggle and a pre-flight confirmation using startGateway()'s existing probe. This PR is the companion docs change the issue anticipated, so please keep #3810 open when this merges.

Posted from the 2026-09-08 open-PR relationship audit (read-only, one auditor per PR); reply here if any of this is wrong.

@adiarora06
adiarora06 force-pushed the codex/remote-gateway-toggle-docs branch from 3fccb03 to 161b7ee Compare September 9, 2026 20:00
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 9, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) September 10, 2026 04:39

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer review (agent-assisted, on behalf of @bolichen97), head 161b7ee24.

Docs-only, one file. Every claim in the new paragraph holds against main: the toggle is Settings → Developer → Gateway → "Run a local gateway" (en.json:8038-8042, settingsRegistry.gen.ts:1267-1273); gateway-supervisor.js:167 reads it once at launch and startGateway() at :577-588 refuses to spawn when it is off, so a gateway must already be answering.

Non-blocking: remote-and-mobile.md:678 "answer on port 5476" is exact only with no Instances host configured; with one configured main.js:113-127 targets that crew's port — "on port 5476 (or the port dashboard.url names)" would be precise.

@bolichen97
bolichen97 merged commit 4d260fc into kirodotdev:main Sep 10, 2026
69 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants