Repository navigation
feat(ci): call the central workflow bodies instead of copying them - #31
Merged
Merged
Conversation
649 lines of workflow become 101 of trigger. This repo is the estate's main-only case, and it is what the derivation was built for: none of the fast-forward triggers carries a target branch, so the body asks whether a dev branch exists and lands on main because there is none. Nothing in these files states that — the copies carried INTEGRATION_BRANCH: main as a literal that had to be kept in step with the trigger by hand. The gate picks up pnpm validate from package.json without being told it exists. The analysis now runs once per change rather than twice, and a prose-only change skips the gate.
Two bodies invoked by one caller shared a concurrency group and cancelled each other — github.workflow resolves to the CALLER's name inside a called workflow, so every body using the conventional expression collided. v0.1.2 gives each group the body's own name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces four copied workflows with calls into
kirchDev/workflows@v0.1.1— 649 lines become 101.This repository is the estate's main-only case, which makes it the proof for the derivation: none of the fast-forward triggers carries a target branch, so the body asks whether a
devbranch exists and lands onmainbecause there is none. No file here states that. The copies carriedINTEGRATION_BRANCH: mainas a literal that had to be kept in step with the trigger by hand.The gate also picks up
pnpm validatefrompackage.jsonwithout being told it exists.Two savings come along: the analysis runs once per change rather than twice (a push to an integration branch always has a PR open on it, and that PR run scans the same tree), and a prose-only change skips the gate.
Check names change to
<caller-job> / <body-job>— a branch-protection rule on an old name would wait forever.