Skip to content

Changed the default value of minRoleToEdit of SettingRefs to STAFF #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SzBeni2003 wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

Changed the default value of minRoleToEdit of SettingRefs to STAFF #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7c95d6
Changed the default value of minRoleToEdit of SettingRefs to STAFF
SzBeni2003 Sep 2, 2026
600292d
Merge branch 'staging' into fix/settingref-minrole
SzBeni2003 Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/main/kotlin/hu/bme/sch/cmsch/setting/DummySetting.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class DummySetting(
data class SettingGroup(
private val fieldName: String,
private val description: String = "",
private val minRoleToEdit: RoleType = RoleType.ADMIN,
private val minRoleToEdit: RoleType = RoleType.STAFF,
) : SettingRegisteringLoader<DummySetting>() {

override fun provideSetting(thisRef: ComponentBase, prop: KProperty<*>): DummySetting =
Expand Down
12 changes: 6 additions & 6 deletions backend/src/main/kotlin/hu/bme/sch/cmsch/setting/SettingRefs.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ data class StringSettingRef(
private val type: SettingType = SettingType.TEXT,
private val fieldName: String? = null,
private val description: String = "",
private val minRoleToEdit: RoleType = RoleType.ADMIN
private val minRoleToEdit: RoleType = RoleType.STAFF
) : SettingRegisteringLoader<SettingRef<String>>() {

override fun provideSetting(thisRef: ComponentBase, prop: KProperty<*>): SettingRef<String> =
Expand Down Expand Up @@ -46,7 +46,7 @@ data class SelectSettingRef(
private val type: SettingType = SettingType.SELECT,
private val fieldName: String? = null,
private val description: String = "",
private val minRoleToEdit: RoleType = RoleType.ADMIN,
private val minRoleToEdit: RoleType = RoleType.STAFF,
) : SettingRegisteringLoader<SettingRef<String>>() {

override fun provideSetting(thisRef: ComponentBase, prop: KProperty<*>): SettingRef<String> =
Expand Down Expand Up @@ -79,7 +79,7 @@ data class EnumSettingRef<T>(
private val type: SettingType = SettingType.SELECT,
private val fieldName: String? = null,
private val description: String = "",
private val minRoleToEdit: RoleType = RoleType.ADMIN
private val minRoleToEdit: RoleType = RoleType.STAFF
) : SettingRegisteringLoader<SettingRef<T>>() where T : Enum<T> {

override fun provideSetting(thisRef: ComponentBase, prop: KProperty<*>): SettingRef<T> =
Expand Down Expand Up @@ -112,7 +112,7 @@ data class JsonSettingRef<T : Any>(
private val type: SettingType = SettingType.JSON,
private val fieldName: String? = null,
private val description: String = "",
private val minRoleToEdit: RoleType = RoleType.ADMIN
private val minRoleToEdit: RoleType = RoleType.STAFF
) : SettingRegisteringLoader<SettingRef<T>>() {

override fun provideSetting(thisRef: ComponentBase, prop: KProperty<*>): SettingRef<T> =
Expand Down Expand Up @@ -143,7 +143,7 @@ data class NumberSettingRef(
private val type: SettingType = SettingType.NUMBER,
private val fieldName: String? = null,
private val description: String = "",
private val minRoleToEdit: RoleType = RoleType.ADMIN
private val minRoleToEdit: RoleType = RoleType.STAFF
) : SettingRegisteringLoader<SettingRef<Long>>() {

override fun provideSetting(thisRef: ComponentBase, prop: KProperty<*>): SettingRef<Long> =
Expand Down Expand Up @@ -174,7 +174,7 @@ data class BooleanSettingRef(
private val type: SettingType = SettingType.BOOLEAN,
private val fieldName: String? = null,
private val description: String = "",
private val minRoleToEdit: RoleType = RoleType.ADMIN
private val minRoleToEdit: RoleType = RoleType.STAFF
) : SettingRegisteringLoader<SettingRef<Boolean>>() {

override fun provideSetting(thisRef: ComponentBase, prop: KProperty<*>): SettingRef<Boolean> =
Expand Down
Loading