Repository navigation
Conversation
added 2 commits
November 14, 2026 10:10
Only probe evidence counted as published inventory, so the item page sat on "Discovering…" and ended at "Unavailable" whenever the pre-play probe did not land, even though the selected version's row already carried audio and subtitle tracks. Render the selected row's own declared rows immediately and label them as coming from the release listing. Probe evidence replaces them, and a probed list never regresses to a declared one. A row with no declaration and no evidence keeps the bounded discovery-then-retry path. The player overlay follows the same rule for the playing version, and a plan's inventory is still published only under the rows it describes, so a substituted release cannot leak onto the selected version.
4 tasks done
Collaborator
Author
|
Superseded by #459, which contains this change plus the rest of the playback reliability bundle. Closing to keep the review surface to one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Related issue: N/A
Validation tasks: none
After #445, only probe evidence counted as published inventory. When the pre-play probe did not land, selecting a version left the action bar on "Discovering audio tracks…" and "Discovering subtitles…" and then "Unavailable", even though the selected row already carried the release's audio and subtitle listing. The same gate hid the playing version's declared inventory in the player's audio and subtitle menus, so viewers could not pick a track before playback.
Approach
The item page renders the selected row's own declared audio and subtitle rows immediately, labelled "From release listing". A declared audio placeholder with no language or codec is grouped instead of rendered as a track. Probe evidence for that exact file replaces the declared view, and a probed list never regresses to a declared one; the player inventory snapshot records whether each list is verified. A row with no declaration and no evidence keeps the bounded discovery state and only offers Retry after that window lapses.
The player overlay follows the same rule for the playing version: plan or version rows show at once with the unverified marker, and only an empty list waits. A plan's inventory is still published only under the rows it describes, so a substituted release cannot appear as the selected version's tracks.
planInventoryDescribesRequestedFileis unchanged.Validation
tsrs -b.make verify-local-pathspasses.--no-verify: the local pre-push gate runs changed-lines Go lint, which needs libvips and is not installed here. This change touches no Go files.Risks
No API, schema, or migration change. The change is display-only: declared rows are labelled, and probe evidence still supersedes them.
Checklist
Evidence: none. The changed menus are covered by component tests; no media attachment was requested.
AI Disclosure
Posted by an AI agent (Muse Spark, OpenCode harness).