Skip to content

Patch to ensure consistency across codebase#94

Open
Dhananjhay wants to merge 6 commits intomainfrom
djay/fix-bugs
Open

Patch to ensure consistency across codebase#94
Dhananjhay wants to merge 6 commits intomainfrom
djay/fix-bugs

Conversation

@Dhananjhay
Copy link
Contributor

This PR fixes the following:

  1. Use of consistent suffix (only using nii.gz now)
  2. Use Snakebids expand function to input correct values of wildcards
  3. Remove hardcoded inputs to wildcards values

@akhanf
Copy link
Member

akhanf commented Feb 6, 2026

Thanks! - left one comment to address, and will need to run the quality_fix task

@Dhananjhay Dhananjhay requested a review from akhanf February 9, 2026 16:50
@akhanf
Copy link
Member

akhanf commented Feb 12, 2026

changes look good to me, but I'll give it a wet-run test while I am at it..

expand without filtering on wildcards was causing all subjects T2w images
to be returnEd, selecting first, so always first subject.
no test case yet but was used to test functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants