fix(security): sanitize verbatim HTML output to prevent XSS - #12
Open
capy-ai[bot] wants to merge 1 commit into
Open
fix(security): sanitize verbatim HTML output to prevent XSS#12capy-ai[bot] wants to merge 1 commit into
capy-ai[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds allowlist-based HTML sanitization to
replaceUrlsinsrc/formatters.nimto prevent XSS attacks from unsanitizedverbatimrendering in Finch view templates.Changes
src/formatters.nim
sanitizeHtml*proc that parses HTML withhtmlparser, walks the tree, strips dangerous tags/attributes, and re-serializes safe outputallowedHtmlTags), denylists (dangerousHtmlTags), void tags (voidHtmlTags), and attribute allowlists (allowedHtmlAttrs)hrefandsrcattributes to only permithttp://,https://, or rooted relative paths (nojavascript:,data:, orvbscript:)replaceUrls*to callsanitizeHtml(body)first, ensuring all content passing through it is sanitized before domain rewritingAll existing
verbatim replaceUrls(...)call sites (tweet bodies, quote tweets, community notes, user bios) are now automatically protected without modifying the view templates.