Repository navigation
ci: add the check, security and codeql workflows and dependabot - #1
Merged
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Explicit imports, private SearchResultDTO fields behind the Lombok accessors, customOpenApi bean method name, javadoc tag order and TODO comment format.
Spotless and Checkstyle (google_checks) run in validate, PMD and SpotBugs after compile, JaCoCo checks 40 percent of lines at verify. Measured coverage is 43 percent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pourquoi
Application du contrat CI de
agent-config(rules/references/ref-ci-github.md) à un projet Java, pour valider la fiche sur une stack autre que Python (kevpdev/yt-transcriber#40).Changements
check(sh ./mvnw -B verify, Java 21 Temurin, cache Maven),security(Trivy),codeql (java-kotlin)etcodeql (actions)non requis. Dependabot surgithub-actionsetmaven. Actions épinglées par SHA.verifycouvre maintenant le format, le lint, l'analyse statique et la couverture, dans l'ordre : Spotless et Checkstyle (google_checks.xml) envalidate, PMD et SpotBugs après la compilation, JaCoCo (seuil 40 % de lignes) enverify.chore(format), 24 fichiers, sans changement de comportement), les corrections des violations, puis l'ajout des plugins.Mesuré
mvnw verifydonnait 12 tests, BUILD SUCCESS. Couverture de lignes mesurée à 43 %, d'où le seuil à 40 %.google_checks.xml: 103 violations au départ. Les règles Javadoc, le suffixeDTOdans les noms et les noms de testshould_..._when_...sont supprimés dansconfig/checkstyle-suppressions.xml. Le reste est corrigé (imports explicites, champs deSearchResultDTOprivés derrière les accesseurs Lombok, méthodecustomOpenApi).catchvide plantés, qu'il détecte. SpotBugs : 4 alertes au départ (champs publics deSearchResultDTO), 0 après correction.jacoco:check(couverture 0,43).checkpasse en 1 min 07.À savoir
Le nom du bean
customOpenAPIdevientcustomOpenApi: aucune référence dans le dépôt.