Fixes to get the code running on my system#83
Open
romanzenka wants to merge 4 commits intokevinkovalchik:masterfrom
Open
Fixes to get the code running on my system#83romanzenka wants to merge 4 commits intokevinkovalchik:masterfrom
romanzenka wants to merge 4 commits intokevinkovalchik:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not recommend you accept this pull request as-is, but I wanted to show you what I did to get the code running on my system. I realize that putting the .dlls in is a bad idea and don't recommend doing so. I wonder if Thermo could be persuaded to maintain a NuGet presence for the sake of all the developers, there should be a way to do that AND also get their licensing done properly.