Skip to content

fix(ci): use github.token fallback in pr-triage workflow when ADK_TRIAGE_AGENT secret is unset #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kerrrang9214-tech merged 4 commits into from
Jun 21, 2026
Merged

fix(ci): use github.token fallback in pr-triage workflow when ADK_TRIAGE_AGENT secret is unset #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9bde2b
Initial plan
Copilot Jun 16, 2026
01c4172
fix(ci): add fallback token for v2 sync workflow
Copilot Jun 16, 2026
288940d
ci(pr-triage): fall back to github.token when ADK_TRIAGE_AGENT secret…
Copilot Jun 21, 2026
3482228
fix(tests): pass exc_type=ImportError to pytest.importorskip for crew…
Copilot Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-triage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:

- name: Run Triaging Script
env:
GITHUB_TOKEN: ${{ secrets.ADK_TRIAGE_AGENT }}
GITHUB_TOKEN: ${{ secrets.ADK_TRIAGE_AGENT || github.token }}
GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
GOOGLE_GENAI_USE_VERTEXAI: 0
OWNER: 'google'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/v2-sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
with:
ref: v2
fetch-depth: 0
token: ${{ secrets.RELEASE_PAT }}
token: ${{ secrets.RELEASE_PAT || github.token }}

- name: Check for new commits on main
id: check
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
- name: Create sync PR
if: steps.check.outputs.behind != '0' && steps.existing.outputs.exists == 'false'
env:
GH_TOKEN: ${{ secrets.RELEASE_PAT }}
GH_TOKEN: ${{ secrets.RELEASE_PAT || github.token }}
run: |
gh pr create \
--base v2 \
Expand Down
8 changes: 6 additions & 2 deletions tests/unittests/integrations/crewai/test_crewai_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,13 @@

import pytest

# Skip entire module if Python < 3.10 (must be before crewai_tool import)
# Skip entire module if crewai is not installed (must be before crewai_tool import).
# exc_type=ImportError is required because crewai_tool.py re-raises the
# ModuleNotFoundError as ImportError, which pytest 9.1+ does not catch by default.
pytest.importorskip(
"google.adk.integrations.crewai.crewai_tool", reason="Requires Python 3.10+"
"google.adk.integrations.crewai.crewai_tool",
reason="Requires crewai package (pip install 'google-adk[extensions]')",
exc_type=ImportError,
)

from google.adk.agents.context import Context
Expand Down
Loading