Add OCI Windows machine images - #429
Conversation
65c40f2 to
dd4f0b7
Compare
dd4f0b7 to
a6c00b9
Compare
ab190c7 to
fbed517
Compare
-->
✱ stlc build✅ go code · compare
✅ python code · compare
✅ typescript code · compare
Diagnostics: ❗ 0 new / 1 total error, 💡 0 new / 5 total note
Build metadata
This comment is auto-generated by stlc and is kept up to date as you push. |
fbed517 to
31b5a61
Compare
0dc80f4 to
2c43db6
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2c43db6. Configure here.

summary
windows-baseartifacts from launchablewindows-imageartifactstargeted tests
Validated after rebasing onto
main: Linux, Darwin, e2e install, Semgrep, Socket, and Windows machine-image CI gates pass.Note
Medium Risk
Changes core image materialization (qemu-img, backing chains) and VM boot configuration (UEFI/TPM disks); mistakes could break launches or leave inconsistent cache dependencies, though Linux paths remain separate.
Overview
Adds bootable Windows desktop disks distributed as OCI images on
windows/amd64, separate from non-bootable Windows container images. Artifacts useio.hypeman.machine-image.*labels forwindows-base(immutable backing disk) andwindows-image(launchable qcow2 delta with digest-pinned base, TPM 2.0, Secure Boot required).The image manager materializes bases from raw/qcow2/VHD/VHDX into immutable sparse
base.raw, copies Windows images toimage.qcow2, and rebases them onto cache-owned bases (rejecting external backing paths, encryption, and unsafe disk features). Base deletion is blocked while any cachedwindows-imagereferences the base digest, including cross-repository base refs.Instance create for Windows skips Linux kernel/config-disk setup, applies higher defaults (8 GiB RAM, 4 vCPUs), reflone-clones the cached image to a writable per-instance qcow2 at fixed virtual size, and boots via UEFI + Secure Boot + TPM (OVMF templates and TPM state paths). Create validation rejects networking, volumes/GPU, hotplug, env/health checks, and mismatched
overlay_size; snapshot/standby/fork paths are rejected until a later phase. Implicit host-platform image resolution no longer fast-paths cached Windows tags.Reviewed by Cursor Bugbot for commit 56c51b4. Bugbot is set up for automated code reviews on this repo. Configure here.