Skip to content

Use kit daemon lifecycle primitives#765

Open
mariusvniekerk wants to merge 7 commits into
mainfrom
use-kit-daemon-lifecycle
Open

Use kit daemon lifecycle primitives#765
mariusvniekerk wants to merge 7 commits into
mainfrom
use-kit-daemon-lifecycle

Conversation

@mariusvniekerk
Copy link
Copy Markdown
Collaborator

Summary

  • replace roborev's custom daemon endpoint/runtime/start plumbing with go.kenn.io/kit daemon primitives
  • drop legacy daemon runtime compatibility for addr/port/daemon.json and require kit-style ping responses
  • keep roborev-specific server, worker, shutdown, and API behavior while delegating shared lifecycle concerns to the kit dependency

Validation

  • go fmt ./cmd/roborev ./internal/daemon
  • go vet ./...
  • go test ./...
  • pre-commit golangci-lint hook

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented Jun 1, 2026

roborev: Fail

Changes need one medium contract-sync fix before merge.

Medium

  • internal/daemon_client/client.gen.go:425: PingInfo now includes the required ok field and /api/ping returns it, but the checked-in generated client and openapi-3.0.json still omit it. This leaves the daemon API contract and generated client out of sync.
    • Fix: Regenerate and commit the OpenAPI spec and daemon client after the PingInfo shape change.

Review type: | Agent: codex | Job: 19339

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented Jun 1, 2026

roborev: Combined Review (ac4a839)

No issues found.


Synthesized from 2 reviews (agents: codex | types: default, security)

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented Jun 1, 2026

roborev: Fail

Likely needs one medium fix: update the Nix vendorHash for the changed Go dependency.

Medium

  • flake.nix:23: go.mod now references a new go.kenn.io/kit pseudo-version, but vendorHash was not updated. Nix buildGoModule vendoring will likely fail with a fixed-output hash mismatch. Regenerate the Nix vendor hash after the final go.mod/go.sum changes and update vendorHash.

Review type: | Agent: codex | Job: 19381

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented Jun 2, 2026

roborev: Combined Review (1a5c2fc)

No issues found.


Synthesized from 2 reviews (agents: codex | types: default, security)

The daemon lifecycle branch was temporarily pinned to a kit pseudo-version so Windows could pick up the token-owner fix before a release existed. Now that go.kenn.io/kit v0.1.1 is published, use the stable tag and refresh the Nix vendor hash for that module graph.

Validation: go fmt ./...; go vet ./...; go test ./...

Generated with Codex
Co-authored-by: Codex <codex@openai.com>
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented Jun 2, 2026

roborev: Combined Review (f43e28c)

No issues found.


Synthesized from 2 reviews (agents: codex | types: default, security)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant