Add roborev release discovery support#9
Closed
cpcloud wants to merge 1 commit into
Closed
Conversation
Roborev resolves releases through GitHub's HTML /releases/latest redirect to avoid unauthenticated api.github.com rate limits, then constructs asset and checksum URLs from the discovered tag. Kit's selfupdate package only supported API release discovery, so roborev could not migrate without either changing updater behavior or duplicating that redirect path. Add a configurable redirect discovery mode and tar.gz asset namer so roborev can keep its existing release layout, including tar.gz Windows artifacts, while moving checksum, download, and install logic into kit. The plan file captures the follow-on roborev migration for a separate Codex worker. Validation: - go build ./... - go tool gotestsum --format pkgname-and-test-fails -- ./... - go vet ./... - go run ./cmd/testify-helper-check ./... - go tool nilaway -include-pkgs=go.kenn.io/kit ./... - nix run 'nixpkgs#golangci-lint' -- run Generated with Codex Co-authored-by: OpenAI Codex <noreply@openai.com>
Contributor
Author
|
This is not right just yet. |
roborev: Combined Review (
|
Contributor
Author
|
Closing this because the direction changed: roborev should adopt kit's existing updater and GitHub release discovery instead of adding roborev-specific release discovery behavior to kit. No kit change is needed here; the follow-up work belongs in the roborev repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation