Repository navigation
Conversation
The PR table cut most titles to about 20 characters, while the same pull requests read in full in Activity. The table lived in a sidebar that could not grow past 600px, and it packed labels, agent state, CI counts, review, and stack controls into the Item cell beside the title. The title was the only part allowed to shrink, and each row cut it at a different point. The table also had its own copy of Activity's cells, with fixed 96px and 64px Repo and Author columns, so the two had already drifted. Activity and the PR table now render the same headers and cells on the same column tracks. A change to one reaches the other. Pull request status has its own column, so no row's status takes room from a title, and labels take only the room the title leaves. A draft shows the Draft chip that merged and closed pull requests already use. The list sidebars no longer stop at 600px. They grow until 360px is left for the detail pane, the rule the Activity rail already follows. The table needs about 400px for its other columns, so it appears from 720px. Narrower sidebars keep the two-line rows, which give the title a full line. The 340-560px table that hid Author and When is gone: it showed less of each title than the rows it replaced. Dragging the sidebar past the window edge was not checked in Firefox. Playwright reported the minimum width for that drag, which may be an artifact of the synthetic pointer leaving the viewport. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
roborev: Combined Review (
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request table now shows whole titles once the sidebar is wide, and the sidebar can be made wide. Before, the table cut most titles to about 20 characters while Activity showed the same pull requests in full. This is a user-facing fix.
Two things caused it. The list sidebar could not grow past 600px. Inside it, the table packed labels, agent state, CI counts, review, and stack controls into the Item cell, where the title was the only part allowed to shrink, so each row cut its title at a different point. The table also carried its own copy of Activity's cells, with fixed 96px and 64px Repo and Author columns, and the two had already drifted.
Most of the diff moves cell markup and CSS out of
ActivityThreaded.svelte,ActivityFeed.svelte, andPullItem.svelteintoItemTableHeaders.svelteandItemTableCells.svelte. The decisions are in three places:PullList.svelteSidebarLayout.svelteItemTableCells.svelte(.item-title--reserved)Not checked: dragging the sidebar past the window's right edge in Firefox. Playwright reported the minimum width for that drag, which may come from the synthetic pointer leaving the viewport; dragging to the edge works.
Model used: Fable 5.2
Co-authored-by: Claude Fable 5.2 noreply@anthropic.com