Skip to content

fix(prs): give PR table titles the room Activity gives them - #2046

Open
wesm wants to merge 1 commit into
mainfrom
pr-table-bad
Open

wesm wants to merge 1 commit into
mainfrom
pr-table-bad

Conversation

@wesm

@wesm wesm commented Nov 19, 2026

Copy link
Copy Markdown
Member

The pull request table now shows whole titles once the sidebar is wide, and the sidebar can be made wide. Before, the table cut most titles to about 20 characters while Activity showed the same pull requests in full. This is a user-facing fix.

Two things caused it. The list sidebar could not grow past 600px. Inside it, the table packed labels, agent state, CI counts, review, and stack controls into the Item cell, where the title was the only part allowed to shrink, so each row cut its title at a different point. The table also carried its own copy of Activity's cells, with fixed 96px and 64px Repo and Author columns, and the two had already drifted.

  • One table. Activity (threaded and flat) and the PR table render the same headers and cells on the same column tracks, so a change to one reaches the other. Repo and Author size to their content up to a cap.
  • Status column. CI, review, stack, and star sit in their own column, so no row's status takes room from a title. Labels take only the room the title leaves.
  • No 600px ceiling. The PR, Issues, and Worklists sidebars drag until 360px is left for the detail pane, the rule the Activity rail already follows. The width persists across reloads.
  • Table from 720px. The other columns need about 400px, so narrower sidebars keep the two-line rows, which give the title a full line. The 340-560px table that hid Author and When is gone: it showed less of each title than the rows it replaced. The setting now reads "Table in a wide sidebar".
  • Draft chip. A draft shows the Draft chip that merged and closed pull requests already use, in place of the orange dot.

Most of the diff moves cell markup and CSS out of ActivityThreaded.svelte, ActivityFeed.svelte, and PullItem.svelte into ItemTableHeaders.svelte and ItemTableCells.svelte. The decisions are in three places:

Where Decision
PullList.svelte The 720px threshold, and the grid that rows, stack members, and repo groups subgrid into
SidebarLayout.svelte The sidebar bound: layout width minus 360px, with the saved width kept until the layout is measured
ItemTableCells.svelte (.item-title--reserved) The title keeps its full text width before labels get any

Not checked: dragging the sidebar past the window's right edge in Firefox. Playwright reported the minimum width for that drag, which may come from the synthetic pointer leaving the viewport; dragging to the edge works.

Model used: Fable 5.2

Co-authored-by: Claude Fable 5.2 noreply@anthropic.com

The PR table cut most titles to about 20 characters, while the same pull
requests read in full in Activity. The table lived in a sidebar that
could not grow past 600px, and it packed labels, agent state, CI counts,
review, and stack controls into the Item cell beside the title. The
title was the only part allowed to shrink, and each row cut it at a
different point.

The table also had its own copy of Activity's cells, with fixed 96px and
64px Repo and Author columns, so the two had already drifted. Activity
and the PR table now render the same headers and cells on the same
column tracks. A change to one reaches the other.

Pull request status has its own column, so no row's status takes room
from a title, and labels take only the room the title leaves. A draft
shows the Draft chip that merged and closed pull requests already use.

The list sidebars no longer stop at 600px. They grow until 360px is
left for the detail pane, the rule the Activity rail already follows.
The table needs about 400px for its other columns, so it appears from
720px. Narrower sidebars keep the two-line rows, which give the title a
full line. The 340-560px table that hid Author and When is gone: it
showed less of each title than the rows it replaced.

Dragging the sidebar past the window edge was not checked in Firefox.
Playwright reported the minimum width for that drag, which may be an
artifact of the synthetic pointer leaving the viewport.

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
@roborev-ci

roborev-ci Bot commented Nov 19, 2026

Copy link
Copy Markdown

roborev: Combined Review (95b26f9)

Verdict: Changes require fixes for 1 finding.

Medium

  • frontend/src/lib/components/sidebar/PullItem.svelte:146-147: Screen-reader users get no row-selection feedback after Shift-click, Cmd/Ctrl-click, or Cmd/Ctrl+A selects PRs for bulk actions. Selection only changes styling; aria-current identifies the opened PR instead. This happens every time in both table and two-line layouts.

    Fix: Restore screen-reader feedback for bulk selection while keeping the currently opened pull request independently identified in both row layouts. Where: frontend/src/lib/components/sidebar/PullItem.svelte


Reviewers: 3x codex, codex (security), codex (test-value) | Synthesis: codex, 1m54s | Total: 8m18s

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant