Repository navigation
fix(workspaces): reach the phone workspace terminal on desktop - #2004
Conversation
roborev: Combined Review (
|
roborev: Combined Review (
|
roborev: Combined Review (
|
Offer the same base terminal as a Workspace tab in standalone local workspaces, including when runtime discovery is pending or unavailable. Keep launched sessions preferred and preserve saved splits across detail visits, without adding a runtime session or changing remote workspaces. Allow concurrent base-terminal attachments while keeping idle-stop exclusive. Each connection retains ownership of its own transport so a phone and desktop can share the running process. Add admission, layout, discovery and cross-device regressions. Local browser and live terminal integration tests remain unrun. Refs kenn-io#1954. Co-authored-by: GPT-6 Astra <noreply@openai.com>
Avoid a workflow-slot teardown error when switching workspaces. Start a new base terminal only while its workspace is visible, while retaining an already mounted connection across navigation. Preserve the shared PTY owner's size when an inactive client attaches without dimensions. Keep initial size defaults for new tmux clients. Update existing terminal tests and fixtures for the separate Workspace tab, retaining their input, clipboard, focus and geometry assertions. Live browser and terminal integration checks were not run locally. Refs kenn-io#1954. Co-authored-by: GPT-6 Astra <noreply@openai.com>
Keep the delayed-details case focused on saved split membership, the shared base identity, and avoiding a runtime launch. The existing navigation case covers socket retention across switching and reopening, including a runtime poll and restored Workspace selection. Co-authored-by: GPT-6 Astra <noreply@openai.com>
The opt-in Rust owner still rejected a second terminal viewer. Count live attachments so phone and desktop can share input and output without one detach ending the other attachment. Preserve the existing output drain, stop, and post-exit bounds. The socket-free lifecycle regression reproduced the premature exit and now passes. Rust and Go static checks passed. Socket-backed end-to-end validation remains unverified locally because the environment prohibits those fixtures. Co-authored-by: GPT-6 Astra <noreply@openai.com>
Require the current base-terminal socket to claim resize before the first phone input and both desktop attachment inputs. Keep the shared process identity, output, and failed runtime discovery assertions unchanged. The mocked terminal tests and Chromium/Firefox collection passed, as did frontend core checks. Live browser validation remains unverified locally because this environment prohibits browser fixtures. Co-authored-by: GPT-6 Astra <noreply@openai.com>
Capture the visible slot identity when registering it instead of reading a removed parent session during cleanup. Fix the shared owner and remove the redundant workflow-only null guard. Update the existing fixtures to use complete terminal settings, retain the base Workspace pane, and observe the base connection heartbeat before input. Keep shared-process and diff-output assertions intact. The socket-free navigation regression reproduced the null-key exception and now passes. Related unit tests, frontend core checks, collection, and non-mutating lint passed. Live browser validation remains unverified locally because the environment prohibits browser fixtures. Co-authored-by: GPT-6 Astra <noreply@openai.com>
The shared-terminal test now opens a second websocket on the same terminal. Main turned the bodyclose lint back on after this branch started, so that new dial failed lint once the branch was rebased. Close the handshake response on a failed dial, the same way the other dials in this file do. Generated with Claude Code (claude-opus-5-5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bd1e532 to
8c9af36
Compare
roborev: Combined Review (
|
You can continue work started in your phone's Workspace terminal from the standalone desktop Workspaces view for local workspaces.
Select Workspace to reach the same running
claudeprocess, which was previously absent from desktop. Both layouts can stay attached, even while session discovery is pending or unavailable.Live browser and terminal integration checks have not been run locally.
Closes #1954
Co-authored-by: GPT-6 Astra noreply@openai.com
Model used: GPT-6 Astra