Allow click-to-carry pokemon and sell with hotkey while held - #4056
Open
jorgejuniordev wants to merge 2 commits into
Open
Allow click-to-carry pokemon and sell with hotkey while held#4056jorgejuniordev wants to merge 2 commits into
jorgejuniordev wants to merge 2 commits into
Conversation
Clicking a board pokemon now attaches it to the cursor without holding the mouse button, and pressing the sell key (default E) sells the currently dragged or carried unit.
Replace nested if/else branches with guard clauses and small try/can helpers for clearer sell and pickup handling.
Collaborator
|
I just tested your code and I still need to hold the mouse button to drag a Pokémon. Have you tested this code or did you just prompt an AI ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E) sells the currently dragged or click-carried pokemon, not only the hovered one.Test plan
E: it should sell without dropping on the sell zoneEmid-drag: it should sellE(existing behavior): it should still sell