Add iBazel protocol forwarding#99
Open
longlho wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Wrapping protocol-aware dev servers in multirun currently consumes iBazel's stdin protocol at the parent, so children such as
js_run_devservermiss rebuild notifications and HMR degrades.What changed
multirun(..., ibazel_notify_changes = True), which advertises legacy and v1 iBazel notification capabilities and runs children in parallel.commandwrappers.IBAZEL_EVENTmessages only to v1 children.Depends on ibazel@v0.30.0+ for structured
IBAZEL_EVENTnotifications. Legacy notifications continue to work with existing iBazel releases.Related: bazelbuild/bazel-watcher#833
Verification
Ran patched iBazel against the fixture and confirmed notifications arrive before stdin closes. Legacy events reach both legacy and v1 children, structured events reach only v1 children, and the plain child receives neither.