Skip to content

fix: allow deleting a reminder by external id after it's been completed #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keith merged 1 commit into from
Jul 31, 2026
Merged

fix: allow deleting a reminder by external id after it's been completed #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Sources/RemindersLibrary/Reminders.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,17 @@ public final class Reminders {
let calendar = self.calendar(withName: name)
let semaphore = DispatchSemaphore(value: 0)

self.reminders(on: [calendar], displayOptions: .incomplete) { reminders in
// Numeric indexes are only meaningful against the same display set that
// `show` uses by default (incomplete-only), so keep that scope when the
// caller passes a plain integer index — otherwise a numeric index would
// resolve against a differently-ordered/sized array than the one the
// user actually saw. External identifiers are stable regardless of
// completion state, so widen the fetch to `.all` in that case, so a
// reminder already marked complete can still be found and deleted by
// its id instead of failing with "No reminder at index ...".
let displayOptions: DisplayOptions = Int(index) == nil ? .all : .incomplete

self.reminders(on: [calendar], displayOptions: displayOptions) { reminders in
guard let reminder = self.getReminder(from: reminders, at: index) else {
print("No reminder at index \(index) on \(name)")
exit(1)
Expand Down
Loading